Skip to content

refactor: Mark Down headings for the PR template #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

texastony
Copy link
Contributor

Issue #, if available:

Description of changes:
I prefer using Mark Down headings over italics to delineate the sections of a PR description.
In general,
I find we either completely ignore the descriptions (author & reviewer),
or we want to use them to detail a significant amount of detail.

For the second case,
I think headings is more useful.

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@texastony texastony requested a review from a team as a code owner March 24, 2025 00:22
Copy link
Contributor

@ajewellamz ajewellamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@texastony texastony merged commit 8c4de2b into main Mar 24, 2025
196 checks passed
@texastony texastony deleted the tony/chore-pr-template-mark-down branch March 24, 2025 03:12
lucasmcdonald3 pushed a commit that referenced this pull request Mar 24, 2025
## [1.10.0](v1.9.0...v1.10.0) (2025-03-24)

### Features -- Go

* **go:** Go smithy-dafny-standard-library v0.2.0 release ([#1219](#1219)) ([a6b9fb6](a6b9fb6))

### Miscellaneous

* add kms:GenerateRandom permission to CI role ([#1345](#1345)) ([56ebd5d](56ebd5d))
* clarify InFlightTTLExceeded exception ([#1169](#1169)) ([d1c42a6](d1c42a6))
* **deps:** extend supported version of pytz library ([#1333](#1333)) ([6f6876a](6f6876a))
* Enable local testing ([#1282](#1282)) ([70e5809](70e5809))
* expand prettier ignore ([#1270](#1270)) ([094c01c](094c01c))
* fix typos in smithy models ([#1326](#1326)) ([7f59a7e](7f59a7e))
* let fileio deal in uint8 instead of bv8 ([#1347](#1347)) ([80e28f3](80e28f3))
* Mark Down headings for the PR template ([#1351](#1351)) ([8c4de2b](8c4de2b))
* re-enable Dafny for MacOS ([#1343](#1343)) ([aa2bed1](aa2bed1))
* re-enable macOS CI ([#1346](#1346)) ([ed1f804](ed1f804))
* remove mac os from CI and refactor base64Lemmas ([#1325](#1325)) ([6067d3e](6067d3e))
* update releaserc ([#1312](#1312)) ([1a43584](1a43584))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants