Exit Python installation script following installation failures

rahulrajaram · rahulrajaram · commit b9a390a603d6 · 2019-04-30T21:26:19.000-07:00
Future steps may rely on the existence of Python. If Python installation
fails, subsequent statements will fail. To preclude subsequent failures,
the script will exit immediately following failure to install.
diff --git a/scripts/install-python.ps1 b/scripts/install-python.ps1
@@ -51,8 +51,10 @@ function Install-Python {
         Write-Host "Installation completed successfully." -ForegroundColor Green
     } elseif ($install.ExitCode -eq 1602) {
         Write-Host "Installer was exited by the user." -ForegroundColor Red
+        Exit 1
     } else {
         Write-Host "Installation failed with exit code $install.ExitCode" -ForegroundColor Red
+        Exit 1
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -51,8 +51,10 @@ function Install-Python {`
`51`	`51`	`Write-Host "Installation completed successfully." -ForegroundColor Green`
`52`	`52`	`} elseif ($install.ExitCode -eq 1602) {`
`53`	`53`	`Write-Host "Installer was exited by the user." -ForegroundColor Red`
	`54`	`+ Exit 1`
`54`	`55`	`} else {`
`55`	`56`	`Write-Host "Installation failed with exit code $install.ExitCode" -ForegroundColor Red`
	`57`	`+ Exit 1`
`56`	`58`	`}`
`57`	`59`	`}`
`58`	`60`