Run new Go tool 'go fix' on non-codegen files (#3337)

* Run new Go tool 'go fix' on non-codegen files

* Add changelog

Author: Madrigal

.changelog/b3378a34ab4e46e5aa2c9d8835a2cabb.json

@@ -0,0 +1,32 @@
+{
+    "id": "b3378a34-ab4e-46e5-aa2c-9d8835a2cabb",
+    "type": "bugfix",
+    "collapse": true,
+    "description": "Modernize non codegen files with go fix",
+    "modules": [
+        "aws/protocol/eventstream",
+        "config",
+        "feature/cloudfront/sign",
+        "feature/dynamodb/expression",
+        "feature/ec2/imds",
+        "feature/s3/manager",
+        "feature/s3/transfermanager",
+        "internal/codegen",
+        "internal/configsources",
+        "internal/endpoints/v2",
+        "internal/ini",
+        "internal/v4a",
+        "service/bedrockruntime/internal/testing",
+        "service/dynamodb",
+        "service/internal/checksum",
+        "service/internal/endpoint-discovery",
+        "service/internal/integrationtest",
+        "service/internal/presigned-url",
+        "service/internal/s3shared",
+        "service/kinesis/internal/testing",
+        "service/s3",
+        "service/s3control",
+        "service/sqs",
+        "service/transcribestreaming/internal/testing"
+    ]
+}

aws/protocol/eventstream/debug.go

@@ -82,9 +82,9 @@ type decodedHeaders Headers
 
 func (hs *decodedHeaders) UnmarshalJSON(b []byte) error {
 	var jsonHeaders []struct {
-		Name  string      `json:"name"`
-		Type  valueType   `json:"type"`
-		Value interface{} `json:"value"`
+		Name  string    `json:"name"`
+		Type  valueType `json:"type"`
+		Value any       `json:"value"`
 	}
 
 	decoder := json.NewDecoder(bytes.NewReader(b))
@@ -106,7 +106,7 @@ func (hs *decodedHeaders) UnmarshalJSON(b []byte) error {
 	return nil
 }
 
-func valueFromType(typ valueType, val interface{}) (Value, error) {
+func valueFromType(typ valueType, val any) (Value, error) {
 	switch typ {
 	case trueValueType:
 		return BoolValue(true), nil

aws/protocol/eventstream/decode_test.go

@@ -105,7 +105,7 @@ func TestDecoder_DecodeMultipleMessages(t *testing.T) {
 	)
 
 	r := bytes.NewBuffer(nil)
-	for i := 0; i < expectMsgCount; i++ {
+	for range expectMsgCount {
 		r.Write(testEncodedMsg)
 	}
 

aws/protocol/eventstream/encode.go

@@ -157,7 +157,7 @@ func EncodeHeaders(w io.Writer, headers Headers) error {
 	return nil
 }
 
-func binaryWriteFields(w io.Writer, order binary.ByteOrder, vs ...interface{}) error {
+func binaryWriteFields(w io.Writer, order binary.ByteOrder, vs ...any) error {
 	for _, v := range vs {
 		if err := binary.Write(w, order, v); err != nil {
 			return err

aws/protocol/eventstream/encode_test.go

@@ -64,7 +64,7 @@ func TestEncoder_Limits(t *testing.T) {
 	}
 
 	headers := make(Headers, 0, 10_000) // Previously we failed if headers size was above a certain size
-	for i := 0; i < 10_000; i++ {
+	for range 10_000 {
 		headers = append(headers, h)
 	}
 

aws/protocol/eventstream/error.go

@@ -7,7 +7,7 @@ type LengthError struct {
 	Part  string
 	Want  int
 	Have  int
-	Value interface{}
+	Value any
 }
 
 func (e LengthError) Error() string {

aws/protocol/eventstream/header.go

@@ -34,7 +34,7 @@ func (hs *Headers) Set(name string, value Value) {
 // Get returns the Value associated with the header. Nil is returned if the
 // value does not exist.
 func (hs Headers) Get(name string) Value {
-	for i := 0; i < len(hs); i++ {
+	for i := range hs {
 		if h := hs[i]; h.Name == name {
 			return h.Value
 		}

aws/protocol/eventstream/header_value.go

@@ -62,7 +62,7 @@ type rawValue struct {
 	Value []byte // byte representation of value, BigEndian encoding.
 }
 
-func (r rawValue) encodeScalar(w io.Writer, v interface{}) error {
+func (r rawValue) encodeScalar(w io.Writer, v any) error {
 	return binaryWriteFields(w, binary.BigEndian,
 		r.Type,
 		v,
@@ -158,7 +158,7 @@ func decodeStringValue(r io.Reader) (string, error) {
 
 // Value represents the abstract header value.
 type Value interface {
-	Get() interface{}
+	Get() any
 	String() string
 	valueType() valueType
 	encode(io.Writer) error
@@ -169,7 +169,7 @@ type Value interface {
 type BoolValue bool
 
 // Get returns the underlying type
-func (v BoolValue) Get() interface{} {
+func (v BoolValue) Get() any {
 	return bool(v)
 }
 
@@ -196,7 +196,7 @@ func (v BoolValue) encode(w io.Writer) error {
 type Int8Value int8
 
 // Get returns the underlying value.
-func (v Int8Value) Get() interface{} {
+func (v Int8Value) Get() any {
 	return int8(v)
 }
 
@@ -234,7 +234,7 @@ func (v *Int8Value) decode(r io.Reader) error {
 type Int16Value int16
 
 // Get returns the underlying value.
-func (v Int16Value) Get() interface{} {
+func (v Int16Value) Get() any {
 	return int16(v)
 }
 
@@ -271,7 +271,7 @@ func (v *Int16Value) decode(r io.Reader) error {
 type Int32Value int32
 
 // Get returns the underlying value.
-func (v Int32Value) Get() interface{} {
+func (v Int32Value) Get() any {
 	return int32(v)
 }
 
@@ -308,7 +308,7 @@ func (v *Int32Value) decode(r io.Reader) error {
 type Int64Value int64
 
 // Get returns the underlying value.
-func (v Int64Value) Get() interface{} {
+func (v Int64Value) Get() any {
 	return int64(v)
 }
 
@@ -345,7 +345,7 @@ func (v *Int64Value) decode(r io.Reader) error {
 type BytesValue []byte
 
 // Get returns the underlying value.
-func (v BytesValue) Get() interface{} {
+func (v BytesValue) Get() any {
 	return []byte(v)
 }
 
@@ -383,7 +383,7 @@ func (v *BytesValue) decode(r io.Reader) error {
 type StringValue string
 
 // Get returns the underlying value.
-func (v StringValue) Get() interface{} {
+func (v StringValue) Get() any {
 	return string(v)
 }
 
@@ -421,7 +421,7 @@ func (v *StringValue) decode(r io.Reader) error {
 type TimestampValue time.Time
 
 // Get returns the underlying value.
-func (v TimestampValue) Get() interface{} {
+func (v TimestampValue) Get() any {
 	return time.Time(v)
 }
 
@@ -478,7 +478,7 @@ func timeFromEpochMilli(t int64) time.Time {
 type UUIDValue [16]byte
 
 // Get returns the underlying value.
-func (v UUIDValue) Get() interface{} {
+func (v UUIDValue) Get() any {
 	return v[:]
 }
 

aws/protocol/eventstream/header_value_test.go

@@ -9,7 +9,7 @@ import (
 	"time"
 )
 
-func binWrite(v interface{}) []byte {
+func binWrite(v any) []byte {
 	var w bytes.Buffer
 	binary.Write(&w, binary.BigEndian, v)
 	return w.Bytes()

config/config.go

@@ -103,7 +103,7 @@ var defaultAWSConfigResolvers = []awsConfigResolver{
 //
 // General the Config type will use type assertion against the Provider interfaces
 // to extract specific data from the Config.
-type Config interface{}
+type Config any
 
 // A loader is used to load external configuration data and returns it as
 // a generic Config type.
@@ -170,8 +170,8 @@ func (cs configs) ResolveAWSConfig(ctx context.Context, resolvers []awsConfigRes
 
 // ResolveConfig calls the provide function passing slice of configuration sources.
 // This implements the aws.ConfigResolver interface.
-func (cs configs) ResolveConfig(f func(configs []interface{}) error) error {
-	var cfgs []interface{}
+func (cs configs) ResolveConfig(f func(configs []any) error) error {
+	var cfgs []any
 	for i := range cs {
 		cfgs = append(cfgs, cs[i])
 	}