Skip to content

Many packages in gamma.3 release miss ESM distributions #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AllanZhengYP opened this issue Jul 10, 2020 · 3 comments
Closed

Many packages in gamma.3 release miss ESM distributions #1364

AllanZhengYP opened this issue Jul 10, 2020 · 3 comments
Assignees
Labels
bug This issue is a bug.

Comments

@AllanZhengYP
Copy link
Contributor

Describe the bug
With #1297 ideally all the packages should be released with ESModule and CJS module. But appearantly not all the packages contains ESM.
For example most of the packages under packages constains ./dist/cjs exists, ./dist/es is missing.

SDK version number
Example: @aws-sdk/[email protected]

Is the issue in the browser/Node.js/ReactNative?
Browser

To Reproduce (observed behavior)
yarn add @aws-sdk/[email protected] and find the node_modules/@aws-sdk/middleware-serde/dist/es

Expected behavior
node_modules/@aws-sdk/middleware-serde/dist/es should exist.

Screenshots

click to unfold

Screen Shot 2020-07-10 at 4 55 12 PM

@AllanZhengYP AllanZhengYP added the bug This issue is a bug. label Jul 10, 2020
@trivikr
Copy link
Member

trivikr commented Jul 14, 2020

Checked with @aws-sdk/[email protected], node_modules/@aws-sdk/middleware-serde/dist/es still doesn't exist

@trivikr
Copy link
Member

trivikr commented Aug 6, 2020

Verified that @aws-sdk/middleware-serde is released as es from 1.0.0-gamma.4 onwards.

To verify:

$ yarn add @aws-sdk/middleware-serde@gamma

$ ls node_modules/@aws-sdk/middleware-serde/dist/
cjs	es

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

3 participants