Skip to content

Commit 63ea3ab

Browse files
authored
Cleanup (#202)
* DummySegment and DummySubSegment creation * Revert "DummySegment and DummySubSegment creation" This reverts commit 4edb4b5. * Revert "Revert "DummySegment and DummySubSegment creation"" This reverts commit 0442d84. * ran gofmt command to remove golint warnings * remove redundent declaration * Added Dummysegment creation logic * Added reviewdog suggestions * modified code based on feedback * clean up before release
1 parent fff49d3 commit 63ea3ab

File tree

1 file changed

+0
-24
lines changed

1 file changed

+0
-24
lines changed

xray/client_test.go

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -336,14 +336,6 @@ func TestRoundTripReuseDatarace(t *testing.T) {
336336
}()
337337
}
338338
wg.Wait()
339-
340-
// FIXME: @shogo82148 sometimes fail with context deadline exceeded
341-
// for i := 0; i < n; i++ {
342-
// _, err := td.Recv()
343-
// if !assert.NoError(t, err) {
344-
// return
345-
// }
346-
// }
347339
}
348340

349341
func TestRoundTripReuseTLSDatarace(t *testing.T) {
@@ -373,14 +365,6 @@ func TestRoundTripReuseTLSDatarace(t *testing.T) {
373365
}()
374366
}
375367
wg.Wait()
376-
377-
// FIXME: @shogo82148 sometimes fail with context deadline exceeded
378-
// for i := 0; i < n; i++ {
379-
// _, err := td.Recv()
380-
// if !assert.NoError(t, err) {
381-
// return
382-
// }
383-
// }
384368
}
385369

386370
func TestRoundTripReuseHTTP2Datarace(t *testing.T) {
@@ -423,14 +407,6 @@ func TestRoundTripReuseHTTP2Datarace(t *testing.T) {
423407
}()
424408
}
425409
wg.Wait()
426-
427-
// FIXME: @shogo82148 sometimes fail with context deadline exceeded
428-
// for i := 0; i < n; i++ {
429-
// _, err := td.Recv()
430-
// if !assert.NoError(t, err) {
431-
// return
432-
// }
433-
// }
434410
}
435411

436412
// Benchmarks

0 commit comments

Comments
 (0)