Skip to content

Commit 1ba3e1c

Browse files
authored
fix: fix session name typo in get_last_k_turns (#104)
1 parent 207e3e0 commit 1ba3e1c

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

src/bedrock_agentcore/memory/session.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -622,7 +622,7 @@ def list_branches(self, actor_id: str, session_id: str) -> List[Branch]:
622622
def get_last_k_turns(
623623
self,
624624
actor_id: str,
625-
sesssion_id: str,
625+
session_id: str,
626626
k: int = 5,
627627
branch_name: Optional[str] = None,
628628
include_branches: bool = False,
@@ -639,7 +639,7 @@ def get_last_k_turns(
639639
try:
640640
events = self.list_events(
641641
actor_id=actor_id,
642-
session_id=sesssion_id,
642+
session_id=session_id,
643643
branch_name=branch_name,
644644
include_parent_events=include_branches,
645645
max_results=max_results,

tests/bedrock_agentcore/memory/test_session.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -942,7 +942,7 @@ def test_get_last_k_turns_success(self):
942942
with patch.object(manager, "list_events", return_value=mock_events):
943943
result = manager.get_last_k_turns(
944944
actor_id="user-123",
945-
sesssion_id="session-456", # Note: typo in original method signature
945+
session_id="session-456",
946946
k=2,
947947
)
948948

@@ -963,7 +963,7 @@ def test_get_last_k_turns_empty_events(self):
963963

964964
# Mock empty list_events
965965
with patch.object(manager, "list_events", return_value=[]):
966-
result = manager.get_last_k_turns(actor_id="user-123", sesssion_id="session-456", k=5)
966+
result = manager.get_last_k_turns(actor_id="user-123", session_id="session-456", k=5)
967967

968968
assert result == []
969969

@@ -987,7 +987,7 @@ def test_get_last_k_turns_client_error(self):
987987
),
988988
):
989989
with pytest.raises(ClientError):
990-
manager.get_last_k_turns(actor_id="user-123", sesssion_id="session-456", k=5)
990+
manager.get_last_k_turns(actor_id="user-123", session_id="session-456", k=5)
991991

992992
def test_get_event_success(self):
993993
"""Test get_event successful execution."""
@@ -1836,7 +1836,7 @@ def test_get_last_k_turns_turn_grouping(self):
18361836
)
18371837
]
18381838
with patch.object(manager, "list_events", return_value=mock_events):
1839-
result = manager.get_last_k_turns(actor_id="user-123", sesssion_id="session-456", k=5)
1839+
result = manager.get_last_k_turns(actor_id="user-123", session_id="session-456", k=5)
18401840

18411841
# Should group into 2 turns
18421842
assert len(result) == 2
@@ -2027,7 +2027,7 @@ def test_get_last_k_turns_no_conversational_payload(self):
20272027
)
20282028
]
20292029
with patch.object(manager, "list_events", return_value=mock_events):
2030-
result = manager.get_last_k_turns(actor_id="user-123", sesssion_id="session-456", k=5)
2030+
result = manager.get_last_k_turns(actor_id="user-123", session_id="session-456", k=5)
20312031

20322032
assert len(result) == 0 # No turns due to no conversational messages
20332033

@@ -2053,7 +2053,7 @@ def test_get_last_k_turns_break_on_k_limit(self):
20532053
)
20542054

20552055
with patch.object(manager, "list_events", return_value=mock_events):
2056-
result = manager.get_last_k_turns(actor_id="user-123", sesssion_id="session-456", k=3)
2056+
result = manager.get_last_k_turns(actor_id="user-123", session_id="session-456", k=3)
20572057

20582058
# Should only return 3 turns even though there are 10 events
20592059
assert len(result) == 3
@@ -3016,7 +3016,7 @@ def test_get_last_k_turns_with_include_branches_true(self):
30163016
with patch.object(manager, "list_events", return_value=mock_events) as mock_list_events:
30173017
result = manager.get_last_k_turns(
30183018
actor_id="user-123",
3019-
sesssion_id="session-456",
3019+
session_id="session-456",
30203020
k=2,
30213021
branch_name="test-branch",
30223022
include_branches=True, # This should trigger include_parent_events=True

0 commit comments

Comments
 (0)