Skip to content

Commit aa977d9

Browse files
authored
fix: not dev-installable using NPM (#1124)
1 parent fadca18 commit aa977d9

File tree

5 files changed

+39
-58
lines changed

5 files changed

+39
-58
lines changed

.github/workflows/build.yml

Lines changed: 18 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.mergify.yml

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.projenrc.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,4 +69,13 @@ const project = new cdk.JsiiProject({
6969
// disable go sumdb so that go deps are resolved directly against github
7070
project.tasks.tryFind('package').prependExec('go env -w GOSUMDB=off');
7171

72+
// Also check that our dependency closure is installable using NPM, not just yarn
73+
// (Not just additional steps, make it separate job)
74+
project.buildWorkflow?.addPostBuildJobCommands(
75+
'installable_with_npm',
76+
['npm --version && npm install'],
77+
{ checkoutRepo: true },
78+
);
79+
80+
7281
project.synth();

package.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

yarn.lock

Lines changed: 9 additions & 57 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)