Skip to content

Commit 5cb1fbc

Browse files
authored
chore: Update Makefile to include creating test binary with release target (#75)
1 parent 05a4038 commit 5cb1fbc

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

.github/actions/ci/kubetest2/action.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ runs:
7373
shell: bash
7474
run: |
7575
# Store absolute path to e2e binary
76-
echo "e2e_binary=$(pwd)/bin/e2e.test" >> $GITHUB_OUTPUT
76+
echo "e2e_binary=$(pwd)/bin/eks-node-monitoring-agent.test" >> $GITHUB_OUTPUT
7777
7878
# Create a test script that kubetest2 will execute
7979
# Values are embedded directly because kubetest2 exec tester
@@ -83,7 +83,7 @@ runs:
8383
8484
IMAGE="${{ inputs.image }}"
8585
TEST_FILTER="${{ inputs.test_filter }}"
86-
E2E_BINARY="$(pwd)/bin/e2e.test"
86+
E2E_BINARY="$(pwd)/bin/eks-node-monitoring-agent.test"
8787
8888
echo "Running e2e tests with image: \${IMAGE}"
8989
echo "Test filter: \${TEST_FILTER:-<none>}"

Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -307,19 +307,19 @@ update-e2e-manifests: ## Generate e2e agent manifest template from Helm chart
307307
build-e2e: ## Build e2e test binary
308308
@echo "Building e2e test binary..."
309309
@mkdir -p $(OUTPUT_BIN)
310-
go test -c -tags=e2e -o $(OUTPUT_BIN)/e2e.test ./e2e/
311-
@echo "Built $(OUTPUT_BIN)/e2e.test"
310+
go test -c -tags=e2e -o $(OUTPUT_BIN)/eks-node-monitoring-agent.test ./e2e/
311+
@echo "Built $(OUTPUT_BIN)/eks-node-monitoring-agent.test"
312312

313313
.PHONY: e2e
314314
e2e: update-e2e-manifests build-e2e ## Build and run e2e tests against the current cluster context
315-
$(OUTPUT_BIN)/e2e.test --test.v --test.timeout 60m --install=true --image=$(IMAGE_URI) $(ARGS)
315+
$(OUTPUT_BIN)/eks-node-monitoring-agent.test --test.v --test.timeout 60m --install=true --image=$(IMAGE_URI) $(ARGS)
316316

317317
# =============================================================================
318318
# Release Target
319319
# =============================================================================
320320

321321
.PHONY: release
322-
release: build test helm-package ## Build, test, and package for release
322+
release: build test build-e2e helm-package ## Build, test, and package for release
323323
@echo "Release build completed successfully"
324324
@echo "Artifacts:"
325325
@echo " - Helm chart: $(CHART_OUTPUT_DIR)/"

monitors/nvidia/dcgm/fake/dcgm_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ import (
99
"time"
1010

1111
dcgmapi "github.com/NVIDIA/go-dcgm/pkg/dcgm"
12-
"github.com/stretchr/testify/assert"
1312
"github.com/aws/eks-node-monitoring-agent/monitors/nvidia/dcgm/fake"
13+
"github.com/stretchr/testify/assert"
1414
)
1515

1616
func Test(t *testing.T) {

0 commit comments

Comments
 (0)