Skip to content

Commit c1cae63

Browse files
author
Malav Shastri
committed
revert: don't force automatic bucket creation if user don't specify it
1 parent 37a36c8 commit c1cae63

File tree

1 file changed

+8
-7
lines changed
  • src/sagemaker/jumpstart/hub

1 file changed

+8
-7
lines changed

src/sagemaker/jumpstart/hub/hub.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@
3333
from sagemaker.jumpstart.hub.utils import (
3434
get_hub_model_version,
3535
get_info_from_hub_resource_arn,
36+
create_hub_bucket_if_it_does_not_exist,
37+
generate_default_hub_bucket_name,
3638
create_s3_object_reference_from_uri,
3739
construct_hub_arn_from_name,
3840
)
@@ -88,11 +90,12 @@ def _fetch_hub_bucket_name(self) -> str:
8890
if hub_output_location:
8991
location = create_s3_object_reference_from_uri(hub_output_location)
9092
return location.bucket
93+
default_bucket_name = generate_default_hub_bucket_name(self._sagemaker_session)
9194
JUMPSTART_LOGGER.warning(
92-
"There is not a Hub bucket associated with %s.",
95+
"There is not a Hub bucket associated with %s. Using %s",
9396
self.hub_name,
9497
)
95-
return None
98+
return default_bucket_name
9699
except exceptions.ClientError:
97100
JUMPSTART_LOGGER.warning(
98101
"There is not a Hub bucket associated with %s.",
@@ -127,18 +130,16 @@ def create(
127130
) -> Dict[str, str]:
128131
"""Creates a hub with the given description"""
129132

130-
s3_storage_config = (
131-
{"S3OutputPath": self.hub_storage_location.get_uri()}
132-
if self.hub_storage_location
133-
else None
133+
create_hub_bucket_if_it_does_not_exist(
134+
self.hub_storage_location.bucket, self._sagemaker_session
134135
)
135136

136137
return self._sagemaker_session.create_hub(
137138
hub_name=self.hub_name,
138139
hub_description=description,
139140
hub_display_name=display_name,
140141
hub_search_keywords=search_keywords,
141-
s3_storage_config=s3_storage_config,
142+
s3_storage_config={"S3OutputPath": self.hub_storage_location.get_uri()},
142143
tags=tags,
143144
)
144145

0 commit comments

Comments
 (0)