Skip to content

Commit 53c290a

Browse files
authored
change: undo upgrade mms version and library name (#49)
* change: skip test only for 1.4 framework version gpu py2 * undo upgrade mms version and library name
1 parent 8728b70 commit 53c290a

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

docker/1.4.0/py3/Dockerfile.cpu

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ LABEL com.amazonaws.sagemaker.capabilities.accept-bind-to-port=true
66
ARG PYTHON_VERSION=3.6.6
77
ARG PYTORCH_VERSION=1.4.0
88
ARG TORCHVISION_VERSION=0.5.0
9-
ARG MMS_VERSION=1.1.0
9+
ARG MMS_VERSION=1.0.8
1010

1111
# See http://bugs.python.org/issue19846
1212
ENV LANG C.UTF-8
@@ -64,7 +64,7 @@ RUN conda install -c \
6464
&& conda clean -ya \
6565
&& pip install --upgrade pip --trusted-host pypi.org --trusted-host files.pythonhosted.org \
6666
&& ln -s /opt/conda/bin/pip /usr/local/bin/pip3 \
67-
&& pip install multi-model-server==$MMS_VERSION
67+
&& pip install mxnet-model-server==$MMS_VERSION
6868

6969
RUN useradd -m model-server \
7070
&& mkdir -p /home/model-server/tmp \
@@ -84,4 +84,4 @@ RUN curl https://aws-dlc-licenses.s3.amazonaws.com/pytorch-1.4.0/license.txt -o
8484

8585
EXPOSE 8080 8081
8686
ENTRYPOINT ["python", "/usr/local/bin/dockerd-entrypoint.py"]
87-
CMD ["multi-model-server", "--start", "--mms-config", "/home/model-server/config.properties"]
87+
CMD ["mxnet-model-server", "--start", "--mms-config", "/home/model-server/config.properties"]

docker/1.4.0/py3/Dockerfile.gpu

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ LABEL com.amazonaws.sagemaker.capabilities.accept-bind-to-port=true
77
ARG PYTHON_VERSION=3.6.6
88
ARG PYTORCH_VERSION=1.4.0
99
ARG TORCHVISION_VERSION=0.5.0
10-
ARG MMS_VERSION=1.1.0
10+
ARG MMS_VERSION=1.0.8
1111

1212
# See http://bugs.python.org/issue19846
1313
ENV LANG C.UTF-8
@@ -82,7 +82,7 @@ RUN conda install -c \
8282
&& /opt/conda/bin/conda config --set ssl_verify False \
8383
&& pip install --upgrade pip --trusted-host pypi.org --trusted-host files.pythonhosted.org \
8484
&& ln -s /opt/conda/bin/pip /usr/local/bin/pip3 \
85-
&& pip install multi-model-server==$MMS_VERSION
85+
&& pip install mxnet-model-server==$MMS_VERSION
8686

8787
RUN useradd -m model-server \
8888
&& mkdir -p /home/model-server/tmp \
@@ -102,4 +102,4 @@ RUN curl https://aws-dlc-licenses.s3.amazonaws.com/pytorch-1.4.0/license.txt -o
102102

103103
EXPOSE 8080 8081
104104
ENTRYPOINT ["python", "/usr/local/bin/dockerd-entrypoint.py"]
105-
CMD ["multi-model-server", "--start", "--mms-config", "/home/model-server/config.properties"]
105+
CMD ["mxnet-model-server", "--start", "--mms-config", "/home/model-server/config.properties"]

test/conftest.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,8 @@ def skip_gpu_instance_restricted_regions(region, instance_type):
194194

195195

196196
@pytest.fixture(autouse=True)
197-
def skip_gpu_py2(request, use_gpu, instance_type, py_version):
197+
def skip_gpu_py2(request, use_gpu, instance_type, py_version, framework_version):
198198
is_gpu = use_gpu or instance_type[3] in ['g', 'p']
199-
if request.node.get_closest_marker('skip_gpu_py2') and is_gpu and py_version != 'py3':
199+
if request.node.get_closest_marker('skip_gpu_py2') and is_gpu and py_version != 'py3' \
200+
and framework_version == '1.4.0':
200201
pytest.skip('Skipping the test until mms issue resolved.')

0 commit comments

Comments
 (0)