Jdbc changes to accomodate block and constraint optimizations. (#59)

* Jdbc changes to accomodate block and constraint optimizations.

Also fixes some conversions in writer, boolean and date.

* Fix null handling when retrieving rows in JDBC connector.

1. Null handling fix
2. Fix exception handling in row writer.
3. Add informative log lines.

Author: abhijeetvg

athena-federation-sdk/src/main/java/com/amazonaws/athena/connector/lambda/data/BlockWriter.java

@@ -43,8 +43,9 @@ interface RowWriter
          * are made much simpler by being able to write a small number (<100) rows per call. These often
          * relate to batched operators, scan side joins, or field expansions. Writing too many rows
          * will result in errors related to Block size management and are implementation specific.
+         * @throws Exception internal exception.
          */
-        int writeRows(Block block, int rowNum);
+        int writeRows(Block block, int rowNum) throws Exception;
     }
 
     /**

athena-federation-sdk/src/main/java/com/amazonaws/athena/connector/lambda/data/S3BlockSpiller.java

@@ -169,7 +169,13 @@ public void writeRows(RowWriter rowWriter)
         Block block = inProgressBlock.get();
         int rowCount = block.getRowCount();
 
-        int rows = rowWriter.writeRows(block, rowCount);
+        int rows;
+        try {
+            rows = rowWriter.writeRows(block, rowCount);
+        }
+        catch (Exception ex) {
+            throw (ex instanceof RuntimeException) ? (RuntimeException) ex : new RuntimeException(ex);
+        }
 
         if (rows > maxRowsPerCall) {
             throw new RuntimeException("Call generated more than " + maxRowsPerCall + "rows. Generating " +

athena-federation-sdk/src/main/java/com/amazonaws/athena/connector/lambda/data/SimpleBlockWriter.java

@@ -51,7 +51,13 @@ public void writeRows(BlockWriter.RowWriter rowWriter)
     {
         int rowCount = block.getRowCount();
 
-        int rows = rowWriter.writeRows(block, rowCount);
+        int rows;
+        try {
+            rows = rowWriter.writeRows(block, rowCount);
+        }
+        catch (Exception ex) {
+            throw (ex instanceof RuntimeException) ? (RuntimeException) ex : new RuntimeException(ex);
+        }
 
         if (rows > 0) {
             block.setRowCount(rowCount + rows);

athena-federation-sdk/src/main/java/com/amazonaws/athena/connector/lambda/data/writers/GeneratedRowWriter.java

@@ -107,6 +107,7 @@ public static RowWriterBuilder newBuilder()
     }
 
     public boolean writeRow(Block block, int rowNum, Object context)
+            throws Exception
     {
         checkAndRecompile(block);
 

athena-federation-sdk/src/main/java/com/amazonaws/athena/connector/lambda/data/writers/extractors/BigIntExtractor.java

@@ -38,6 +38,7 @@ public interface BigIntExtractor
      * system row/query from which you need to extract a value.
      * @param dst The 'Holder' that you should write your value to and optionally set the isSet flag to > 0 for non-null
      * or 0 for null.
+     * @throws Exception internal exception
      */
-    void extract(Object context, NullableBigIntHolder dst);
+    void extract(Object context, NullableBigIntHolder dst) throws Exception;
 }

athena-federation-sdk/src/main/java/com/amazonaws/athena/connector/lambda/data/writers/extractors/BitExtractor.java

@@ -38,6 +38,7 @@ public interface BitExtractor
      * system row/query from which you need to extract a value.
      * @param dst The 'Holder' that you should write your value to and optionally set the isSet flag to > 0 for non-null
      * or 0 for null.
+     * @throws Exception internal exception
      */
-    void extract(Object context, NullableBitHolder dst);
+    void extract(Object context, NullableBitHolder dst) throws Exception;
 }

athena-federation-sdk/src/main/java/com/amazonaws/athena/connector/lambda/data/writers/extractors/DateDayExtractor.java

@@ -38,6 +38,7 @@ public interface DateDayExtractor
      * system row/query from which you need to extract a value.
      * @param dst The 'Holder' that you should write your value to and optionally set the isSet flag to > 0 for non-null
      * or 0 for null.
+     * @throws Exception internal exception
      */
-    void extract(Object context, NullableDateDayHolder dst);
+    void extract(Object context, NullableDateDayHolder dst) throws Exception;
 }

athena-federation-sdk/src/main/java/com/amazonaws/athena/connector/lambda/data/writers/extractors/DateMilliExtractor.java

@@ -38,6 +38,7 @@ public interface DateMilliExtractor
      * system row/query from which you need to extract a value.
      * @param dst The 'Holder' that you should write your value to and optionally set the isSet flag to > 0 for non-null
      * or 0 for null.
+     * @throws Exception internal exception
      */
-    void extract(Object context, NullableDateMilliHolder dst);
+    void extract(Object context, NullableDateMilliHolder dst) throws Exception;
 }

athena-federation-sdk/src/main/java/com/amazonaws/athena/connector/lambda/data/writers/extractors/DecimalExtractor.java

@@ -38,6 +38,7 @@ public interface DecimalExtractor
      * system row/query from which you need to extract a value.
      * @param dst The 'Holder' that you should write your value to and optionally set the isSet flag to > 0 for non-null
      * or 0 for null.
+     * @throws Exception internal exception
      */
-    void extract(Object context, NullableDecimalHolder dst);
+    void extract(Object context, NullableDecimalHolder dst) throws Exception;
 }

athena-federation-sdk/src/main/java/com/amazonaws/athena/connector/lambda/data/writers/extractors/Float4Extractor.java

@@ -38,6 +38,7 @@ public interface Float4Extractor
      * system row/query from which you need to extract a value.
      * @param dst The 'Holder' that you should write your value to and optionally set the isSet flag to > 0 for non-null
      * or 0 for null.
+     * @throws Exception internal exception
      */
-    void extract(Object context, NullableFloat4Holder dst);
+    void extract(Object context, NullableFloat4Holder dst) throws Exception;
 }