Add assertion on expected serialization

Per Kerssens · Per Kerssens · commit 8045614a5feb · 2025-09-02T10:45:18.000Z
diff --git a/athena-cloudwatch-metrics/src/test/java/com/amazonaws/athena/connectors/cloudwatch/metrics/MetricDataQuerySerDeTest.java b/athena-cloudwatch-metrics/src/test/java/com/amazonaws/athena/connectors/cloudwatch/metrics/MetricDataQuerySerDeTest.java
@@ -34,7 +34,9 @@
 
 public class MetricDataQuerySerDeTest
 {
-    private static final Logger logger = LoggerFactory.getLogger(MetricDataQuerySerDeTest.class);
+	private static final Logger logger = LoggerFactory.getLogger(MetricDataQuerySerDeTest.class);
+
+	private static final String EXPECTED_SERIALIZATION = "[{\"id\":\"m1\",\"metricStat\":{\"metric\":{\"namespace\":\"namespace\",\"metricName\":\"metricName\",\"dimensions\":[{\"name\":\"dim_name1\",\"value\":\"dim_value1\"},{\"name\":\"dim_name2\",\"value\":\"dim_value2\"}]},\"period\":60,\"stat\":\"p90\",\"unit\":null},\"expression\":null,\"label\":null,\"returnData\":null,\"period\":null,\"accountId\":null}]";
 
     @Test
     public void serializeTest()
@@ -66,6 +68,7 @@ public void serializeTest()
         String actualSerialization = MetricDataQuerySerDe.serialize(metricDataQueries);
         logger.info("serializeTest: {}", actualSerialization);
         List<MetricDataQuery> actual = MetricDataQuerySerDe.deserialize(actualSerialization);
-        assertEquals(metricDataQueries, actual);
+        assertEquals(EXPECTED_SERIALIZATION, actualSerialization);
+		assertEquals(metricDataQueries, actual);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,9 @@`
`34`	`34`
`35`	`35`	`public class MetricDataQuerySerDeTest`
`36`	`36`	`{`
`37`		`- private static final Logger logger = LoggerFactory.getLogger(MetricDataQuerySerDeTest.class);`
	`37`	`+ private static final Logger logger = LoggerFactory.getLogger(MetricDataQuerySerDeTest.class);`
	`38`	`+`
	`39`	`+ private static final String EXPECTED_SERIALIZATION = "[{\"id\":\"m1\",\"metricStat\":{\"metric\":{\"namespace\":\"namespace\",\"metricName\":\"metricName\",\"dimensions\":[{\"name\":\"dim_name1\",\"value\":\"dim_value1\"},{\"name\":\"dim_name2\",\"value\":\"dim_value2\"}]},\"period\":60,\"stat\":\"p90\",\"unit\":null},\"expression\":null,\"label\":null,\"returnData\":null,\"period\":null,\"accountId\":null}]";`
`38`	`40`
`39`	`41`	`@Test`
`40`	`42`	`public void serializeTest()`
`@@ -66,6 +68,7 @@ public void serializeTest()`
`66`	`68`	`String actualSerialization = MetricDataQuerySerDe.serialize(metricDataQueries);`
`67`	`69`	`logger.info("serializeTest: {}", actualSerialization);`
`68`	`70`	`List<MetricDataQuery> actual = MetricDataQuerySerDe.deserialize(actualSerialization);`
`69`		`- assertEquals(metricDataQueries, actual);`
	`71`	`+ assertEquals(EXPECTED_SERIALIZATION, actualSerialization);`
	`72`	`+ assertEquals(metricDataQueries, actual);`
`70`	`73`	`}`
`71`	`74`	`}`