Added unit tests for athena-cloudera-impala Connector (#2880)

Co-authored-by: akshay.kachore <[email protected]>
Co-authored-by: burhan94 <[email protected]>

Author: 3 people

athena-cloudera-impala/src/test/java/com/amazonaws/athena/connectors/cloudera/ImpalaEnvironmentPropertiesTest.java

@@ -32,26 +32,27 @@
 import static com.amazonaws.athena.connector.lambda.connection.EnvironmentConstants.SECRET_NAME;
 import static org.junit.Assert.assertEquals;
 
-public class ImpalaEnvironmentPropertiesTest {
+public class ImpalaEnvironmentPropertiesTest
+{
     Map<String, String> connectionProperties;
     ImpalaEnvironmentProperties impalaEnvironmentProperties;
 
     @Before
-    public void setUp() {
+    public void setUp()
+    {
         connectionProperties = new HashMap<>();
-        connectionProperties.put(HOST, "50.100.00.10");
+        connectionProperties.put(HOST, "localhost");
         connectionProperties.put(DATABASE, "default");
         connectionProperties.put(SECRET_NAME, "testSecret");
         connectionProperties.put(PORT, "49172");
         impalaEnvironmentProperties = new ImpalaEnvironmentProperties();
     }
 
     @Test
-    public void impalaConnectionPropertiesTest() {
-
+    public void testImpalaConnectionProperties()
+    {
         Map<String, String> impalaConnectionProperties = impalaEnvironmentProperties.connectionPropertiesToEnvironment(connectionProperties);
-
-        String expectedConnectionString = "impala://jdbc:impala://50.100.00.10:49172/default;${testSecret}";
+        String expectedConnectionString = "impala://jdbc:impala://localhost:49172/default;${testSecret}";
         assertEquals(expectedConnectionString, impalaConnectionProperties.get(DEFAULT));
     }
-}
+}

athena-cloudera-impala/src/test/java/com/amazonaws/athena/connectors/cloudera/ImpalaFederationExpressionParserTest.java

@@ -0,0 +1,64 @@
+/*-
+ * #%L
+ * athena-cloudera-impala
+ * %%
+ * Copyright (C) 2019 - 2025 Amazon Web Services
+ * %%
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * #L%
+ */
+package com.amazonaws.athena.connectors.cloudera;
+
+import org.apache.arrow.vector.types.pojo.ArrowType;
+import org.junit.Test;
+
+import java.util.Arrays;
+import java.util.Collections;
+
+import static org.junit.Assert.assertEquals;
+
+public class ImpalaFederationExpressionParserTest
+{
+    private static final String IMPALA_QUOTE_CHARACTER = "`";
+    private final ImpalaFederationExpressionParser parser = new ImpalaFederationExpressionParser(IMPALA_QUOTE_CHARACTER);
+
+    @Test
+    public void testWriteArrayConstructorClause_withMultipleElements()
+    {
+        String result = parser.writeArrayConstructorClause(
+            new ArrowType.Int(32, true),
+            Arrays.asList("1", "2", "3")
+        );
+        assertEquals("1, 2, 3", result);
+    }
+
+    @Test
+    public void testWriteArrayConstructorClause_withSingleElement()
+    {
+        String result = parser.writeArrayConstructorClause(
+            new ArrowType.Utf8(),
+            Collections.singletonList("'test'")
+        );
+        assertEquals("'test'", result);
+    }
+
+    @Test
+    public void testWriteArrayConstructorClause_withEmptyList()
+    {
+        String result = parser.writeArrayConstructorClause(
+            new ArrowType.Bool(),
+            Collections.emptyList()
+        );
+        assertEquals("", result);
+    }
+}

athena-cloudera-impala/src/test/java/com/amazonaws/athena/connectors/cloudera/ImpalaJdbcConnectionFactoryTest.java

@@ -7,9 +7,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.