Skip to content

Commit be1c0c2

Browse files
Addressing review comments.
1 parent 60fe5e6 commit be1c0c2

File tree

2 files changed

+8
-21
lines changed

2 files changed

+8
-21
lines changed

athena-synapse/src/main/java/com/amazonaws/athena/connectors/synapse/SynapseJdbcConnectionFactory.java

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121

2222
import com.amazonaws.athena.connector.credentials.CredentialsConstants;
2323
import com.amazonaws.athena.connector.credentials.CredentialsProvider;
24-
import com.amazonaws.athena.connector.credentials.OAuthAccessTokenCredentials;
2524
import com.amazonaws.athena.connectors.jdbc.connection.DatabaseConnectionConfig;
2625
import com.amazonaws.athena.connectors.jdbc.connection.DatabaseConnectionInfo;
2726
import com.amazonaws.athena.connectors.jdbc.connection.GenericJdbcConnectionFactory;
@@ -79,21 +78,9 @@ public Connection getConnection(final CredentialsProvider credentialsProvider)
7978
);
8079
}
8180
else {
82-
// Check if this is OAuth credentials
83-
if (credentialsProvider.getCredential() instanceof OAuthAccessTokenCredentials) {
84-
// OAuth token
85-
OAuthAccessTokenCredentials oauthCreds = (OAuthAccessTokenCredentials) credentialsProvider.getCredential();
86-
connectionProps.setProperty(CredentialsConstants.ACCESS_TOKEN_PROPERTY, oauthCreds.getAccessToken());
87-
secretReplacement = "";
88-
}
89-
else {
90-
// replace aws secret value with credentials and change username as user
91-
secretReplacement = String.format(
92-
"%s;%s",
93-
"user=" + credentialsProvider.getCredentialMap().get(CredentialsConstants.USER),
94-
"password=" + credentialsProvider.getCredentialMap().get(CredentialsConstants.PASSWORD)
95-
);
96-
}
81+
Map<String, String> credentialMap = credentialsProvider.getCredentialMap();
82+
connectionProps.putAll(credentialMap);
83+
secretReplacement = "";
9784
}
9885

9986
derivedJdbcString = secretMatcher.replaceAll(Matcher.quoteReplacement(secretReplacement));

athena-synapse/src/test/java/com/amazonaws/athena/connectors/synapse/SynapseJdbcConnectionFactoryTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@ public void testGetConnectionWithBasicCredentialsSuccess()
119119
credentialMap.put(CredentialsConstants.PASSWORD, TEST_PASSWORD);
120120

121121
when(mockCredentialsProvider.getCredentialMap()).thenReturn(credentialMap);
122-
when(mockCredentialsProvider.getCredential()).thenReturn(null);
123122

124123
connectionFactory = new SynapseJdbcConnectionFactory(
125124
mockDatabaseConnectionConfig,
@@ -138,9 +137,11 @@ public void testGetConnectionWithBasicCredentialsSuccess()
138137
public void testGetConnectionWithOAuthCredentialsSuccess()
139138
{
140139
when(mockDatabaseConnectionConfig.getJdbcConnectionString()).thenReturn(TEST_JDBC_URL_WITH_SECRET);
141-
142-
when(mockCredentialsProvider.getCredential()).thenReturn(mockOAuthCredentials);
143-
when(mockOAuthCredentials.getAccessToken()).thenReturn(TEST_ACCESS_TOKEN);
140+
141+
Map<String, String> credentialMap = new HashMap<>();
142+
credentialMap.put(CredentialsConstants.ACCESS_TOKEN_PROPERTY, TEST_ACCESS_TOKEN);
143+
144+
when(mockCredentialsProvider.getCredentialMap()).thenReturn(credentialMap);
144145

145146
connectionFactory = new SynapseJdbcConnectionFactory(
146147
mockDatabaseConnectionConfig,
@@ -186,7 +187,6 @@ public void testGetConnectionWithNullCredentialsProviderCredentialMapThrowsExcep
186187
when(mockDatabaseConnectionConfig.getJdbcConnectionString()).thenReturn(TEST_JDBC_URL_WITH_SECRET);
187188

188189
when(mockCredentialsProvider.getCredentialMap()).thenReturn(null);
189-
when(mockCredentialsProvider.getCredential()).thenReturn(null);
190190

191191
connectionFactory = new SynapseJdbcConnectionFactory(
192192
mockDatabaseConnectionConfig,

0 commit comments

Comments
 (0)