Skip to content

Conversation

@aws-rafams
Copy link
Contributor

@aws-rafams aws-rafams commented Mar 31, 2025

Fixes #1033

  • Interface changes
  • Build
  • Testing

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@moltar
Copy link

moltar commented Mar 31, 2025

I think this PR introduced a lot of unnecessary formatting changes (replaces ' with ") which makes it difficult to review.

@MichaelWalker-git
Copy link
Contributor

This is weird because prime /eslint should have picked it up.

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.83%. Comparing base (a904686) to head (b5eb9cc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1045    +/-   ##
========================================
  Coverage   94.82%   94.83%            
========================================
  Files          76       76            
  Lines       22885    22912    +27     
  Branches      366      620   +254     
========================================
+ Hits        21701    21728    +27     
  Misses       1184     1184            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@krokoko
Copy link
Collaborator

krokoko commented Apr 1, 2025

LGTM, just need to test it, build is green now

@krokoko
Copy link
Collaborator

krokoko commented Apr 22, 2025

@aws-rafams have you had a chance to test this one ? We can merge it right after :)

@krokoko krokoko enabled auto-merge (squash) May 1, 2025 19:42
@krokoko krokoko merged commit f7d52c1 into main May 1, 2025
19 of 20 checks passed
@krokoko krokoko deleted the 1033-why-does-existingamazonauroravectorstore-require-aurorasecuritygroupid branch May 1, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why does ExistingAmazonAuroraVectorStore require auroraSecurityGroupId?

6 participants