-
Notifications
You must be signed in to change notification settings - Fork 71
fix(aurora): aurora security group CDK native syntax #1045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aurora): aurora security group CDK native syntax #1045
Conversation
|
I think this PR introduced a lot of unnecessary formatting changes (replaces |
|
This is weird because prime /eslint should have picked it up. |
Signed-off-by: Rafael Mosca <[email protected]>
…e-require-aurorasecuritygroupid
…e-require-aurorasecuritygroupid
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1045 +/- ##
========================================
Coverage 94.82% 94.83%
========================================
Files 76 76
Lines 22885 22912 +27
Branches 366 620 +254
========================================
+ Hits 21701 21728 +27
Misses 1184 1184 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
LGTM, just need to test it, build is green now |
…e-require-aurorasecuritygroupid
…e-require-aurorasecuritygroupid
…e-require-aurorasecuritygroupid
…e-require-aurorasecuritygroupid
…e-require-aurorasecuritygroupid
…e-require-aurorasecuritygroupid
…e-require-aurorasecuritygroupid
…e-require-aurorasecuritygroupid
|
@aws-rafams have you had a chance to test this one ? We can merge it right after :) |
…e-require-aurorasecuritygroupid
…e-require-aurorasecuritygroupid
…e-require-aurorasecuritygroupid
…e-require-aurorasecuritygroupid
Fixes #1033
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.