[BOLT] Do not emit debug_names entry for DIEs with DW_AT_declaration

Summary:
Previously BOLT was only doing it for DW_TAG_variables. It looks like other type
of DIEs can have this. So making it global.

Test Plan: ninja check-bolt

Reviewers: maks, davidino, #llvm-bolt

Reviewed By: davidino

Differential Revision: https://phabricator.intern.facebook.com/D57796929

Tasks: T190087639

Author: Alexander Yermolovich

bolt/lib/Core/DebugNames.cpp

@@ -112,8 +112,6 @@ void DWARF5AcceleratorTable::addUnit(DWARFUnit &Unit,
 // Returns true if DW_TAG_variable should be included in .debug-names based on
 // section 6.1.1.1 for DWARF5 spec.
 static bool shouldIncludeVariable(const DWARFUnit &Unit, const DIE &Die) {
-  if (Die.findAttribute(dwarf::Attribute::DW_AT_declaration))
-    return false;
   const DIEValue LocAttrInfo =
       Die.findAttribute(dwarf::Attribute::DW_AT_location);
   if (!LocAttrInfo)
@@ -148,6 +146,8 @@ static bool shouldIncludeVariable(const DWARFUnit &Unit, const DIE &Die) {
 
 bool static canProcess(const DWARFUnit &Unit, const DIE &Die,
                        std::string &NameToUse, const bool TagsOnly) {
+  if (Die.findAttribute(dwarf::Attribute::DW_AT_declaration))
+    return false;
   switch (Die.getTag()) {
   case dwarf::DW_TAG_base_type:
   case dwarf::DW_TAG_class_type: