create spdxid enum #172
Merged
create spdxid enum #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notthatbreezy
approved these changes
Nov 11, 2020
|
Nice update here -- I didn't really think about the list of valid SPDX ids changing much... I think your change is a better solution than refinement in this case for the reasons you mentioned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR creates an SPDX id enum using
enumeratumand replaces the SPDX license checker library we were using. This was necessary because the list of valid SPDX identifiers changes over time, and drift from the list in our library, which hasn't been updated in five years, meant that we were missing some ids, which is important when we reject all values that we don't know how to parse.Checklist
Testing
SpdxIdmake senseCloses #164