Fix defaults

Author: badsyntax

.github/workflows/codeql-analysis.yml

@@ -1,7 +1,7 @@
 # For most projects, this workflow file will not need changing; you simply need
 # to commit it to your repository.
 #
-# You may wish to alter this file to override the set of languages analyzed,
+# You may wish to alter this file to override the set of languages analysed,
 # or to provide custom queries or build logic.
 #
 # ******** NOTE ********

.vscode/settings.json

@@ -27,8 +27,10 @@
   "files.trimTrailingWhitespace": true,
   "cSpell.language": "en-GB",
   "cSpell.words": [
+    "Autobuild",
     "badsyntax",
     "Behavior",
+    "codeql",
     "color",
     "etag",
     "globber",

action.yml

@@ -32,8 +32,6 @@ inputs:
       ETag
       ContentType
       CacheControl
-      LastModified
-      ContentLength
     description: 'A newline-separated list of criteria to define the sync strategy. Criteria include: ETag, ContentType, CacheControl, LastModified, ContentLength'
   strip-extension-glob:
     require: false

dist/index.js

@@ -1,12 +1,13 @@
 import fs from 'node:fs';
 import path from 'node:path';
 import { describe, it, expect } from '@jest/globals';
+import type { HeadObjectCommandOutput } from '@aws-sdk/client-s3';
 import {
   getObjectKeyFromFilePath,
   getFilesFromSrcDir,
   shouldUploadFile,
-} from '../s3';
-import { HeadObjectCommandOutput } from '@aws-sdk/client-s3';
+  generateSyncCriteria,
+} from '../s3.js';
 
 describe('getObjectKeyFromFilePath', () => {
   it('should generate the key', () => {
@@ -53,7 +54,7 @@ describe('shouldUploadFile', () => {
     fs.statSync(absoluteFilePath);
 
   it('should upload if no metadata is specified', async () => {
-    const criteria = 'ETag\nCache-Control';
+    const criteria = generateSyncCriteria('ETag\nCache-Control');
     const metadata = undefined;
     const shouldUpload = await shouldUploadFile(
       absoluteFilePath,
@@ -71,7 +72,7 @@ describe('shouldUploadFile', () => {
   });
 
   it('should upload if no criteria is specified', async () => {
-    const criteria = '';
+    const criteria = generateSyncCriteria('');
     const metadata = { $metadata: {} };
 
     const shouldUpload = await shouldUploadFile(
@@ -90,13 +91,13 @@ describe('shouldUploadFile', () => {
   });
 
   describe('matching criteria', () => {
-    const criteria = `
+    const criteria = generateSyncCriteria(`
       ETag
       ContentType
       CacheControl
       LastModified
       ContentLength
-    `;
+    `);
 
     const metadata: HeadObjectCommandOutput = {
       $metadata: {},

dist/index.js.map

@@ -1,10 +1,4 @@
 import { getInput } from '@actions/core';
-import {
-  defaultConcurrency,
-  defaultLargeFileSizeInMb,
-  defaultMultipartUploadPartsInBytes,
-  defaultSyncStrategy,
-} from './defaults.js';
 
 export function getInputs() {
   const bucket = getInput('bucket', {
@@ -52,44 +46,31 @@ export function getInputs() {
     trimWhitespace: true,
   });
 
-  const _multipartFileSizeMb = parseInt(
+  const multipartFileSizeMb = Number(
     getInput('multipart-file-size-mb', {
       required: false,
       trimWhitespace: true,
-    }),
-    10
+    })
   );
 
-  const multipartFileSizeMb = isNaN(_multipartFileSizeMb)
-    ? defaultLargeFileSizeInMb
-    : _multipartFileSizeMb;
-
-  const _multipartChunkBytes = parseInt(
+  const multipartChunkBytes = Number(
     getInput('multipart-chunk-bytes', {
       required: false,
       trimWhitespace: true,
-    }),
-    10
+    })
   );
 
-  const multipartChunkBytes = isNaN(_multipartChunkBytes)
-    ? defaultMultipartUploadPartsInBytes
-    : _multipartFileSizeMb;
-
-  const _concurrency = parseInt(
+  const concurrency = Number(
     getInput('concurrency', {
       required: false,
       trimWhitespace: true,
     })
   );
 
-  const concurrency = isNaN(_concurrency) ? defaultConcurrency : _concurrency;
-
-  const syncStrategy =
-    getInput('sync-strategy', {
-      required: false,
-      trimWhitespace: true,
-    }) || defaultSyncStrategy;
+  const syncStrategy = getInput('sync-strategy', {
+    required: false,
+    trimWhitespace: true,
+  });
 
   return {
     bucket,