bugfix: cosocket connections from the connection pool might lead to segfaults if it is not used immediately. thanks xukaifu for reporting this as github issue openresty#108.

Author: agentzh

src/ngx_http_lua_socket.c

@@ -3127,6 +3127,11 @@ ngx_http_lua_get_keepalive_peer(ngx_http_request_t *r, lua_State *L,
         u->writer.limit = 0;
         u->request_sent = 0;
 
+#if 1
+        u->write_event_handler = ngx_http_lua_socket_dummy_handler;
+        u->read_event_handler = ngx_http_lua_socket_dummy_handler;
+#endif
+
         if (u->cleanup == NULL) {
             cln = ngx_http_cleanup_add(r, 0);
             if (cln == NULL) {

t/068-socket-keepalive.t

@@ -11,6 +11,10 @@ our $HtmlDir = html_dir;
 
 $ENV{TEST_NGINX_CLIENT_PORT} ||= server_port();
 $ENV{TEST_NGINX_MEMCACHED_PORT} ||= 11211;
+#$ENV{TEST_NGINX_REDIS_PORT} ||= 6379;
+
+$ENV{LUA_PATH} ||=
+    '/usr/local/openresty-debug/lualib/?.lua;/usr/local/openresty/lualib/?.lua;;';
 
 no_long_string();
 #no_diff();
@@ -848,3 +852,50 @@ received response of 119 bytes
 ["lua socket get keepalive peer: using connection",
 'lua socket keepalive create connection pool for key "unix:/tmp/test-nginx.sock"']
 
+
+
+=== TEST 12: github issue #108: ngx.locaiton.capture + redis.set_keepalive
+--- http_config eval
+    qq{
+        lua_package_path "$::HtmlDir/?.lua;;";
+    }
+--- config
+    location /t {
+        default_type text/html;
+        set $port $TEST_NGINX_MEMCACHED_PORT;
+        #lua_code_cache off;
+        lua_need_request_body on;
+        content_by_lua_file html/t.lua;
+    }
+
+    location /anyurl {
+        internal;
+        proxy_pass http://127.0.0.1:$server_port/dummy;
+    }
+
+    location = /dummy {
+        echo dummy;
+    }
+--- user_files
+>>> t.lua
+local sock, err = ngx.socket.connect("127.0.0.1", ngx.var.port)
+if not sock then ngx.say(err) return end
+sock:send("flush_all\r\n")
+sock:receive()
+sock:setkeepalive()
+
+sock, err = ngx.socket.connect("127.0.0.1", ngx.var.port)
+if not sock then ngx.say(err) return end
+local res = ngx.location.capture("/anyurl") --3
+
+ngx.say("ok")
+--- request
+    GET /t
+--- response_body
+ok
+--- error_log
+lua socket get keepalive peer: using connection
+--- no_error_log
+[error]
+[alert]
+