Merge pull request #411 from bavix/develop

drop assert's

Author: rez1dent3

src/Internal/Repository/TransactionRepository.php

@@ -39,14 +39,14 @@ public function insert(array $objects): void
             );
         }
 
-        assert($this->transaction->newQuery()->insert($values) === true);
+        $this->transaction->newQuery()->insert($values);
     }
 
     public function insertOne(TransactionDtoInterface $dto): Transaction
     {
         $attributes = $this->transformer->extract($dto);
         $instance = $this->transaction->newInstance($attributes);
-        assert($instance->saveQuietly() === true);
+        $instance::withoutEvents(static fn () => $instance->save());
 
         return $instance;
     }

src/Internal/Repository/TransferRepository.php

@@ -36,9 +36,7 @@ public function insertOne(TransferDtoInterface $dto): Transfer
     {
         $attributes = $this->transformer->extract($dto);
         $instance = $this->transfer->newInstance($attributes);
-        $instance->saveQuietly();
-
-        assert($instance->getKey() !== null);
+        $instance::withoutEvents(static fn () => $instance->save());
 
         return $instance;
     }

tests/Units/Domain/ConfirmTest.php

@@ -28,6 +28,7 @@ public function testSimple(): void
         self::assertSame(0, $wallet->balanceInt);
 
         $transaction = $wallet->deposit(1000, ['desc' => 'unconfirmed'], false);
+        self::assertTrue($transaction->getKey() > 0);
         self::assertSame(0, $wallet->balanceInt);
         self::assertFalse($transaction->confirmed);
 
@@ -47,6 +48,7 @@ public function testSafe(): void
         $transaction = $wallet->forceWithdraw(1000, ['desc' => 'unconfirmed'], false);
         self::assertSame(0, $wallet->balanceInt);
         self::assertFalse($transaction->confirmed);
+        self::assertTrue($transaction->getKey() > 0);
 
         $wallet->safeConfirm($transaction);
         self::assertSame(0, $wallet->balanceInt);

tests/Units/Domain/WalletExtensionTest.php

@@ -30,6 +30,7 @@ public function testCustomAttribute(): void
         self::assertFalse($buyer->relationLoaded('wallet'));
         $transaction = $buyer->deposit(1000, ['bank_method' => 'VietComBank']);
 
+        self::assertTrue($transaction->getKey() > 0);
         self::assertSame($transaction->amountInt, $buyer->balanceInt);
         self::assertInstanceOf(Transaction::class, $transaction);
         self::assertSame('VietComBank', $transaction->bank_method);
@@ -47,6 +48,7 @@ public function testTransactionMoneyAttribute(): void
         self::assertFalse($buyer->relationLoaded('wallet'));
         $transaction = $buyer->deposit(1000, ['currency' => 'EUR']);
 
+        self::assertTrue($transaction->getKey() > 0);
         self::assertSame($transaction->amountInt, $buyer->balanceInt);
         self::assertInstanceOf(TransactionMoney::class, $transaction);
         self::assertSame('1000', $transaction->currency->getAmount());