Rename out to out_diagnostics (#4341)

**What type of PR is this?**

Refactor

**What does this PR do? Why is it needed?**

Follow-up to #4269

**Which issues(s) does this PR fix?**

**Other notes for review**

Author: fmeum

go/private/actions/archive.bzl

@@ -64,14 +64,14 @@ def emit_archive(go, source = None, _recompile_suffix = "", recompile_internal_d
     # nogo is a FilesToRunProvider and some targets don't have it, some have it but no executable.
     if nogo != None and nogo.executable != None:
         out_facts = go.declare_file(go, name = source.name, ext = pre_ext + ".facts")
-        out_nogo = go.declare_directory(go, name = source.name, ext = pre_ext + "_nogo")
+        out_diagnostics = go.declare_directory(go, name = source.name, ext = pre_ext + "_nogo")
         if validate_nogo(go):
             out_nogo_validation = go.declare_file(go, name = source.name, ext = pre_ext + ".nogo")
         else:
             out_nogo_validation = None
     else:
         out_facts = None
-        out_nogo = None
+        out_diagnostics = None
         out_nogo_validation = None
 
     direct = source.deps
@@ -116,7 +116,7 @@ def emit_archive(go, source = None, _recompile_suffix = "", recompile_internal_d
             out_lib = out_lib,
             out_export = out_export,
             out_facts = out_facts,
-            out_nogo = out_nogo,
+            out_diagnostics = out_diagnostics,
             out_nogo_validation = out_nogo_validation,
             nogo = nogo,
             out_cgo_export_h = out_cgo_export_h,
@@ -145,7 +145,7 @@ def emit_archive(go, source = None, _recompile_suffix = "", recompile_internal_d
             out_lib = out_lib,
             out_export = out_export,
             out_facts = out_facts,
-            out_nogo = out_nogo,
+            out_diagnostics = out_diagnostics,
             out_nogo_validation = out_nogo_validation,
             nogo = nogo,
             gc_goopts = source.gc_goopts,
@@ -190,7 +190,7 @@ def emit_archive(go, source = None, _recompile_suffix = "", recompile_internal_d
         facts_file = out_facts,
         runfiles = source.runfiles,
         _validation_output = out_nogo_validation,
-        _nogo_fix_output = out_nogo,
+        _nogo_diagnostics = out_diagnostics,
         _cgo_deps = cgo_deps,
     )
     x_defs = dict(source.x_defs)

go/private/actions/compilepkg.bzl

@@ -68,7 +68,7 @@ def emit_compilepkg(
         out_lib = None,
         out_export = None,
         out_facts = None,
-        out_nogo = None,
+        out_diagnostics = None,
         out_nogo_validation = None,
         nogo = None,
         out_cgo_export_h = None,
@@ -85,8 +85,8 @@ def emit_compilepkg(
     have_nogo = nogo != None and nogo.executable != None
     if have_nogo != (out_facts != None):
         fail("nogo must be specified if and only if out_facts is specified", nogo)
-    if have_nogo != (out_nogo != None):
-        fail("nogo must be specified if and only if out_nogo is specified", nogo)
+    if have_nogo != (out_diagnostics != None):
+        fail("nogo must be specified if and only if out_diagnostics is specified", nogo)
 
     if cover and go.coverdata:
         archives = archives + [go.coverdata]
@@ -215,7 +215,7 @@ def emit_compilepkg(
             sources = sources,
             cgo_go_srcs = cgo_go_srcs_for_nogo,
             archives = archives,
-            out = out_nogo,
+            out_diagnostics = out_diagnostics,
             out_facts = out_facts,
             out_validation = out_nogo_validation,
             nogo = nogo,
@@ -228,7 +228,7 @@ def _run_nogo(
         sources,
         cgo_go_srcs,
         archives,
-        out,
+        out_diagnostics,
         out_facts,
         out_validation,
         nogo):
@@ -239,7 +239,7 @@ def _run_nogo(
                      [archive.data.facts_file for archive in archives if archive.data.facts_file] +
                      [archive.data.export_file for archive in archives])
     inputs_transitive = [sdk.tools, sdk.headers, go.stdlib.libs]
-    outputs = [out, out_facts]
+    outputs = [out_diagnostics, out_facts]
 
     nogo_args = go.tool_args(go)
     if cgo_go_srcs:
@@ -248,7 +248,7 @@ def _run_nogo(
 
     nogo_args.add_all(archives, before_each = "-facts", map_each = _facts)
     nogo_args.add("-out_facts", out_facts)
-    nogo_args.add_all("-out", [out], expand_directories = False)
+    nogo_args.add_all("-out", [out_diagnostics], expand_directories = False)
     nogo_args.add("-nogo", nogo.executable)
 
     # This action runs nogo and produces the facts files for downstream nogo actions.
@@ -278,10 +278,10 @@ def _run_nogo(
         validation_args = go.actions.args()
         validation_args.add("nogovalidation")
         validation_args.add(out_validation)
-        validation_args.add_all([out], expand_directories = False)
+        validation_args.add_all([out_diagnostics], expand_directories = False)
 
         go.actions.run(
-            inputs = [out],
+            inputs = [out_diagnostics],
             outputs = [out_validation],
             mnemonic = "ValidateNogo",
             executable = go.toolchain._builder,

go/private/rules/binary.bzl

@@ -152,14 +152,14 @@ def _go_binary_impl(ctx):
         executable = executable,
     )
     validation_output = archive.data._validation_output
-    nogo_fix_output = archive.data._nogo_fix_output
+    nogo_diagnostics = archive.data._nogo_diagnostics
 
     providers = [
         archive,
         OutputGroupInfo(
             cgo_exports = archive.cgo_exports,
             compilation_outputs = [archive.data.file],
-            nogo_fix = [nogo_fix_output] if nogo_fix_output else [],
+            nogo_fix = [nogo_diagnostics] if nogo_diagnostics else [],
             _validation = [validation_output] if validation_output else [],
         ),
     ]

go/private/rules/library.bzl

@@ -49,7 +49,7 @@ def _go_library_impl(ctx):
     go_info = new_go_info(go, ctx.attr)
     archive = go.archive(go, go_info)
     validation_output = archive.data._validation_output
-    nogo_fix_output = archive.data._nogo_fix_output
+    nogo_diagnostics = archive.data._nogo_diagnostics
 
     return [
         go_info,
@@ -66,7 +66,7 @@ def _go_library_impl(ctx):
         OutputGroupInfo(
             cgo_exports = archive.cgo_exports,
             compilation_outputs = [archive.data.file],
-            nogo_fix = [nogo_fix_output] if nogo_fix_output else [],
+            nogo_fix = [nogo_diagnostics] if nogo_diagnostics else [],
             _validation = [validation_output] if validation_output else [],
         ),
     ]

go/private/rules/test.bzl

@@ -69,7 +69,7 @@ def _go_test_impl(ctx):
     )
 
     validation_outputs = []
-    nogo_fix_outputs = []
+    nogo_diagnosticss = []
 
     # Compile the library to test with internal white box tests
     internal_go_info = new_go_info(
@@ -80,8 +80,8 @@ def _go_test_impl(ctx):
     internal_archive = go.archive(go, internal_go_info)
     if internal_archive.data._validation_output:
         validation_outputs.append(internal_archive.data._validation_output)
-    if internal_archive.data._nogo_fix_output:
-        nogo_fix_outputs.append(internal_archive.data._nogo_fix_output)
+    if internal_archive.data._nogo_diagnostics:
+        nogo_diagnosticss.append(internal_archive.data._nogo_diagnostics)
     go_srcs = [src for src in internal_go_info.srcs if src.extension == "go"]
 
     # Compile the library with the external black box tests
@@ -102,8 +102,8 @@ def _go_test_impl(ctx):
     external_archive = go.archive(go, external_go_info, is_external_pkg = True)
     if external_archive.data._validation_output:
         validation_outputs.append(external_archive.data._validation_output)
-    if external_archive.data._nogo_fix_output:
-        nogo_fix_outputs.append(external_archive.data._nogo_fix_output)
+    if external_archive.data._nogo_diagnostics:
+        nogo_diagnosticss.append(external_archive.data._nogo_diagnostics)
 
     # now generate the main function
     repo_relative_rundir = ctx.attr.rundir or ctx.label.package or "."
@@ -218,7 +218,7 @@ def _go_test_impl(ctx):
         ),
         OutputGroupInfo(
             compilation_outputs = [internal_archive.data.file],
-            nogo_fix = nogo_fix_outputs,
+            nogo_fix = nogo_diagnosticss,
             _validation = validation_outputs,
         ),
         coverage_common.instrumented_files_info(