Skip to content

Commit 6907367

Browse files
committed
fixup! Support internal tests
1 parent 118ce4e commit 6907367

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

go/tools/gazelle/rules/generator.go

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,13 @@ const (
2727
// defaultLibName is the name of the default go_library rule in a Go
2828
// package directory. It must be consistent to _DEFAULT_LIB in go/def.bzl.
2929
defaultLibName = "go_default_library"
30+
// defaultTestName is a name of an internal test corresponding to
31+
// defaultLibName. It does not need to be consistent to something but it
32+
// just needs to be unique in the Bazel package
33+
defaultTestName = "go_default_test"
34+
// defaultXTestName is a name of an external test corresponding to
35+
// defaultLibName.
36+
defaultXTestName = "go_default_xtest"
3037
)
3138

3239
// Generator generates Bazel build rules for Go build targets
@@ -119,8 +126,8 @@ func (g *generator) generate(rel string, pkg *build.Package) (*bzl.Rule, error)
119126

120127
func (g *generator) generateTest(rel string, pkg *build.Package, library string) (*bzl.Rule, error) {
121128
name := library + "_test"
122-
if library == "go_default_library" {
123-
name = "go_default_test"
129+
if library == defaultLibName {
130+
name = defaultTestName
124131
}
125132
attrs := []keyvalue{
126133
{key: "name", value: name},
@@ -140,8 +147,8 @@ func (g *generator) generateTest(rel string, pkg *build.Package, library string)
140147

141148
func (g *generator) generateXTest(rel string, pkg *build.Package, library string) (*bzl.Rule, error) {
142149
name := library + "_xtest"
143-
if library == "go_default_library" {
144-
name = "go_default_xtest"
150+
if library == defaultLibName {
151+
name = defaultXTestName
145152
}
146153
attrs := []keyvalue{
147154
{key: "name", value: name},

0 commit comments

Comments
 (0)