Skip to content

Commit 6e8f191

Browse files
committed
fix: Exclude test on windows
1 parent c03a7fc commit 6e8f191

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

.bazelci/presubmit.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,7 @@ tasks:
156156
- "-//tests/core/cgo:generated_versioned_dylib_test"
157157
- "-//tests/core/coverage:coverage_test"
158158
- "-//tests/core/coverage:issue3017_test"
159+
- "-//tests/core/coverage:issue4414_test"
159160
- "-//tests/core/coverage:reassign_flag_commandline_test"
160161
- "-//tests/core/go_binary:go_default_test"
161162
- "-//tests/core/go_path:go_path_test"

tests/core/coverage/issue4414_test.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@ func TestMain(m *testing.M) {
2626
-- issue.go --
2727
package internal
2828
29+
func OK() {
30+
// This is a no-op function
31+
}
32+
2933
-- issue_test.go --
3034
package internal
3135
@@ -34,7 +38,7 @@ import (
3438
)
3539
3640
func TestOK(t *testing.T) {
37-
41+
OK()
3842
}
3943
4044
-- BUILD.bazel --
@@ -55,7 +59,7 @@ go_test(
5559
}
5660

5761
func TestIssue4414(t *testing.T) {
58-
if err := bazel_testing.RunBazel("coverage", "--instrument_test_targets", "--combined_report=lcov", "//:issue_test"); err != nil {
62+
if err := bazel_testing.RunBazel("coverage", "--instrument_test_targets", "//:issue_test"); err != nil {
5963
t.Fatal(err)
6064
}
6165
}

0 commit comments

Comments
 (0)