Inline private variable (#518)

* Inline private variable

* Remove public facing use of deprecated FileType

Author: andyscott

scala/private/rule_impls.bzl

@@ -25,7 +25,6 @@ load(
     "write_manifest",
 )
 
-_jar_filetype = FileType([".jar"])
 _java_filetype = FileType([".java"])
 _scala_filetype = FileType([".scala"])
 _srcjar_filetype = FileType([".srcjar"])

scala/scala.bzl

@@ -12,8 +12,6 @@ load(
     "@io_bazel_rules_scala//specs2:specs2_junit.bzl",
     _specs2_junit_dependencies = "specs2_junit_dependencies")
 
-_jar_filetype = FileType([".jar"])
-
 _launcher_template = {
     "_java_stub_template": attr.label(
         default = Label("@java_stub_template//file")),
@@ -101,10 +99,9 @@ _junit_resolve_deps = {
 
 # Common attributes reused across multiple rules.
 _common_attrs_for_plugin_bootstrapping = {
-    "srcs": attr.label_list(
-        allow_files = FileType([".scala", ".srcjar", ".java"])),
+    "srcs": attr.label_list(allow_files = [".scala", ".srcjar", ".java"]),
     "deps": attr.label_list(),
-    "plugins": attr.label_list(allow_files = FileType([".jar"])),
+    "plugins": attr.label_list(allow_files = [".jar"]),
     "runtime_deps": attr.label_list(),
     "data": attr.label_list(allow_files = True, cfg = "data"),
     "resources": attr.label_list(allow_files = True),
@@ -128,7 +125,7 @@ _common_attrs.update({
         default = Label(
             "@io_bazel_rules_scala//third_party/plugin/src/main:dependency_analyzer"
         ),
-        allow_files = _jar_filetype,
+        allow_files = [".jar"],
         mandatory = False),
 })