Skip to content

Commit b0fc510

Browse files
authored
specify deps for specs2 and specs2-junit deps (#1002)
* specify deps for specs2 deps needed for strict-deps/unused-deps * Update specs2.bzl * Update specs2_junit.bzl * Update specs2_junit.bzl * Update aspect.bzl * Update aspect.bzl
1 parent c734eb3 commit b0fc510

File tree

3 files changed

+13
-2
lines changed

3 files changed

+13
-2
lines changed

specs2/specs2.bzl

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ def specs2_repositories(
4242
major_version,
4343
),
4444
artifact_sha256 = scala_version_jar_shas["specs2_common"],
45+
deps = ["@io_bazel_rules_scala_org_specs2_specs2_fp"],
4546
licenses = ["notice"],
4647
server_urls = maven_servers,
4748
)
@@ -53,6 +54,10 @@ def specs2_repositories(
5354
major_version,
5455
),
5556
artifact_sha256 = scala_version_jar_shas["specs2_core"],
57+
deps = [
58+
"@io_bazel_rules_scala_org_specs2_specs2_common",
59+
"@io_bazel_rules_scala_org_specs2_specs2_matcher",
60+
],
5661
licenses = ["notice"],
5762
server_urls = maven_servers,
5863
)
@@ -75,6 +80,7 @@ def specs2_repositories(
7580
major_version,
7681
),
7782
artifact_sha256 = scala_version_jar_shas["specs2_matcher"],
83+
deps = ["@io_bazel_rules_scala_org_specs2_specs2_common"],
7884
licenses = ["notice"],
7985
server_urls = maven_servers,
8086
)

specs2/specs2_junit.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ def specs2_junit_repositories(
4242
major_version,
4343
),
4444
artifact_sha256 = scala_jar_shas[major_version]["specs2_junit"],
45+
deps = ["@io_bazel_rules_scala_org_specs2_specs2_core"],
4546
licenses = ["notice"],
4647
server_urls = maven_servers,
4748
)

test/aspect/aspect.bzl

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,10 @@ def _rule_impl(ctx):
4343
"@io_bazel_rules_scala_org_hamcrest_hamcrest_core//:io_bazel_rules_scala_org_hamcrest_hamcrest_core",
4444
# From specs2/specs2.bzl:specs2_dependencies()
4545
"@io_bazel_rules_scala//specs2:specs2",
46+
"@io_bazel_rules_scala_org_specs2_specs2_common//:io_bazel_rules_scala_org_specs2_specs2_common",
47+
"@io_bazel_rules_scala_org_specs2_specs2_core//:io_bazel_rules_scala_org_specs2_specs2_core",
48+
"@io_bazel_rules_scala_org_specs2_specs2_fp//:io_bazel_rules_scala_org_specs2_specs2_fp",
49+
"@io_bazel_rules_scala_org_specs2_specs2_matcher//:io_bazel_rules_scala_org_specs2_specs2_matcher",
4650
"@io_bazel_rules_scala_scala_xml//:io_bazel_rules_scala_scala_xml",
4751
"@io_bazel_rules_scala_scala_parser_combinators//:io_bazel_rules_scala_scala_parser_combinators",
4852
"@io_bazel_rules_scala_scala_library//:io_bazel_rules_scala_scala_library",
@@ -53,8 +57,8 @@ def _rule_impl(ctx):
5357
}
5458
content = ""
5559
for target in ctx.attr.targets:
56-
visited = sorted(target.visited)
57-
expected = sorted(expected_deps[target.label.name])
60+
visited = depset(sorted(target.visited)).to_list()
61+
expected = depset(sorted(expected_deps[target.label.name])).to_list()
5862
if visited != expected:
5963
content += """
6064
echo Expected these deps from {name}: 1>&2

0 commit comments

Comments
 (0)