Skip to content

JSON worker support #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnynek opened this issue Feb 24, 2022 · 2 comments
Open

JSON worker support #1361

johnynek opened this issue Feb 24, 2022 · 2 comments

Comments

@johnynek
Copy link
Contributor

these rules were early (the earliest?) adopters of the worker protocol, which uses protobuf, but the proto dependency has caused a lot of issues:

#779 #1254 #1305

but recently, bazel has supported a json protocol:

https://blog.bazel.build/2020/11/11/json-workers.html

I am skeptical that such a simple json parse and generation could possibly harm performance (compared to the runtime of the compiler itself) so given the history of problems, this migration seems worth attempting.

I can probably find time to send a PR if this seems like something the current maintainers would accept.

@johnynek
Copy link
Contributor Author

this could also sidestep the need to solve: #1330

@liucijus
Copy link
Collaborator

liucijus commented Mar 3, 2022

Yes, I like the idea to simplify workers using json. It would be great if we could keep protobuf implementation for some time too and than remove it if json implementation performs well.

PRs are more than welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants