-
-
Notifications
You must be signed in to change notification settings - Fork 287
Protobuf and gRPC Support #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yes. It could be. You could see the Twitter Scrooge rules as examples of how you might do this. |
@azymnis here is our protobuf/grpc issue. Can you comment here if you are working? I think we have someone at Stripe who will also chime in soon. |
@johnynek sure, I could pick this up this week. If anyone else has already done this though or they are close, let me know so we don't do double work |
@johnynek @ittaiz here's an ugly way to do this. Bundle scalapb's Then we can have a FWIW this seems to be the approach that bazel has taken internally with protobuf and grpc: https://github.com/bazelbuild/bazel/blob/master/third_party/protobuf/BUILD |
yeah, that sounds right. I would call it to see how we did this with scrooge. To "bundle" we point to the jar (or binary if we really have to) that bazel can pull down and run. |
I'll start working on this today. If anyone has picked this up already please speak up |
I'd not call my work all that close, TBH, mainly due to major unfamiliarity with bazel concepts. |
@jxm-stripe do you have a PR up? |
indeed. again thank you for your work! |
It would be awesome if there any way to support generating, compiling and linking in gRPC service definitions in Scala (using ScalaPB).
https://github.com/scalapb/ScalaPB
Is this something could be potentially incorporated into rules_scala?
The text was updated successfully, but these errors were encountered: