From b88177ed97c88e204a0b4aa1ce957f0766c3762c Mon Sep 17 00:00:00 2001 From: Jamie Date: Wed, 5 Feb 2020 16:01:09 -0800 Subject: [PATCH 1/2] Ignore scalatest in unused dependency checker --- scala/private/phases/phase_compile.bzl | 1 + 1 file changed, 1 insertion(+) diff --git a/scala/private/phases/phase_compile.bzl b/scala/private/phases/phase_compile.bzl index 2aa683bba..f9e60b3bb 100644 --- a/scala/private/phases/phase_compile.bzl +++ b/scala/private/phases/phase_compile.bzl @@ -99,6 +99,7 @@ def phase_compile_scalatest(ctx, p): unused_dependency_checker_ignored_targets = [ target.label for target in p.scalac_provider.default_classpath + + [ctx.attr._scalatest] + ctx.attr.unused_dependency_checker_ignored_targets ], ) From 92160c5ed49ec64d2cce1022d73e3e2b29b4cd7a Mon Sep 17 00:00:00 2001 From: Jamie Date: Wed, 5 Feb 2020 16:15:07 -0800 Subject: [PATCH 2/2] lint --- scala/private/phases/phase_compile.bzl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scala/private/phases/phase_compile.bzl b/scala/private/phases/phase_compile.bzl index f9e60b3bb..1b19e2a98 100644 --- a/scala/private/phases/phase_compile.bzl +++ b/scala/private/phases/phase_compile.bzl @@ -99,7 +99,7 @@ def phase_compile_scalatest(ctx, p): unused_dependency_checker_ignored_targets = [ target.label for target in p.scalac_provider.default_classpath + - [ctx.attr._scalatest] + + [ctx.attr._scalatest] + ctx.attr.unused_dependency_checker_ignored_targets ], )