Support warn/default strict deps in java_common.compile.

Fixes #3626.

PiperOrigin-RevId: 167687039

Author: iirina

src/main/java/com/google/devtools/build/lib/rules/java/JavaSkylarkCommon.java

@@ -264,9 +264,10 @@ private static NestedSet<Artifact> asArtifactNestedSet(Object o) throws EvalExce
         positional = false,
         named = true,
         type = String.class,
-        doc = "A string that specifies how to handle strict deps. Possible values: 'OFF' (silently"
-          + " allowing referencing transitive dependencies) and 'ERROR' (failing to build when"
-          + " transitive dependencies are used directly). By default 'OFF'."
+        doc = "A string that specifies how to handle strict deps. Possible values: 'OFF', 'ERROR',"
+          + "'WARN' and 'DEFAULT'. For more details see "
+          + "https://docs.bazel.build/versions/master/bazel-user-manual.html#flag--strict_java_deps"
+          + ". By default 'ERROR'."
       ),
       @Param(
         name = "java_toolchain",
@@ -332,7 +333,7 @@ public JavaInfo createJavaCompileAction(
         JavaInfo.fetchProvidersFromList(exports, JavaCompilationArgsProvider.class);
     helper.addAllDeps(depsCompilationArgsProviders);
     helper.addAllExports(exportsCompilationArgsProviders);
-    helper.setCompilationStrictDepsMode(getStrictDepsMode(strictDepsMode));
+    helper.setCompilationStrictDepsMode(getStrictDepsMode(strictDepsMode.toUpperCase()));
     MiddlemanProvider hostJavabaseProvider = hostJavabase.getProvider(MiddlemanProvider.class);
 
     helper.addAllPlugins(
@@ -464,7 +465,10 @@ private static StrictDepsMode getStrictDepsMode(String strictDepsMode) {
       case "OFF":
         return StrictDepsMode.OFF;
       case "ERROR":
+      case "DEFAULT":
         return StrictDepsMode.ERROR;
+      case "WARN":
+        return StrictDepsMode.WARN;
       default:
         throw new IllegalArgumentException(
             "StrictDepsMode "

src/test/shell/bazel/bazel_java_test.sh

@@ -1068,6 +1068,27 @@ EOF
   expect_log "Message from C"
 }
 
+function test_java_sandwich_default_strict_deps() {
+  mkdir -p java/com/google/sandwich
+  touch java/com/google/sandwich/{BUILD,A.java,java_custom_library.bzl}
+  write_java_custom_rule
+
+  cat > java/com/google/sandwich/BUILD << EOF
+load(':java_custom_library.bzl', 'java_custom_library')
+
+java_custom_library(
+  name = "custom",
+  srcs = ["A.java"]
+)
+EOF
+
+  sed -i -- 's/ERROR/DEFAULT/g' 'java/com/google/sandwich/java_custom_library.bzl'
+  bazel build java/com/google/sandwich:custom > $TEST_log || fail "Java sandwich build failed"
+
+  sed -i -- 's/DEFAULT/WARN/g' 'java/com/google/sandwich/java_custom_library.bzl'
+  bazel build java/com/google/sandwich:custom > $TEST_log || fail "Java sandwich build failed"
+}
+
 function test_basic_java_sandwich_with_transitive_deps_and_java_library_should_fail() {
   mkdir -p java/com/google/sandwich
   touch java/com/google/sandwich/{BUILD,{A,B,C,Main}.java,java_custom_library.bzl}