Skip to content

Commit 9bb5541

Browse files
authored
Merge branch 'master' into layout-change
2 parents e9b3245 + 8610ef9 commit 9bb5541

File tree

15 files changed

+198
-86
lines changed

15 files changed

+198
-86
lines changed

.eslintrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@
4343
"newline-before-return": "error",
4444
"space-before-blocks": "error",
4545
"no-unused-vars": "error",
46+
"no-multi-spaces": "warn",
4647
"comma-spacing": ["error", { "before": false, "after": true }],
4748
"prefer-destructuring": ["error", {
4849
"VariableDeclarator": {

package-lock.json

Lines changed: 76 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@bbc/react-transcript-editor",
33
"description": "A React component to make transcribing audio and video easier and faster.",
4-
"version": "0.2.0",
4+
"version": "0.2.1",
55
"keywords": [
66
"transcript",
77
"transcriptions",
@@ -82,6 +82,7 @@
8282
"prop-types": "^15.6.2",
8383
"react": "^16.6.0",
8484
"react-dom": "^16.6.0",
85-
"react-keyboard-shortcuts": "^1.1.3"
85+
"react-keyboard-shortcuts": "^1.1.3",
86+
"react-simple-tooltip": "^2.3.3"
8687
}
8788
}

src/lib/TranscriptEditor/MediaPlayer/RollBack.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class RollBack extends React.Component {
1919
onChange={ this.props.handleChangeReplayRollbackValue }
2020
/>
2121
<br/>
22-
<button type="button" onClick={ this.props.rollBack }></button>
22+
<button type="button" onClick={ this.props.rollBack }></button>
2323

2424
</div>
2525
);

src/lib/TranscriptEditor/MediaPlayer/defaultHotKeys.js

Lines changed: 43 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@ function returnHotKeys(self) {
22
return {
33
'alt+space': {
44
priority: 1,
5-
handler: () => {
6-
self.togglePlayMedia();
7-
8-
self.props.handleAnalyticsEvents({
9-
category: 'defaultHotKeys',
10-
action: 'alt+space',
11-
name: 'togglePlayMedia',
5+
handler: () => {
6+
self.togglePlayMedia();
7+
8+
self.props.handleAnalyticsEvents({
9+
category: 'defaultHotKeys',
10+
action: 'alt+space',
11+
name: 'togglePlayMedia',
1212
value: 'na'
1313
});
1414

@@ -18,12 +18,12 @@ function returnHotKeys(self) {
1818
'shift+right': {
1919
priority: 1,
2020
handler: () => {
21-
self.skipForward();
21+
self.skipForward();
2222

23-
self.props.handleAnalyticsEvents({
24-
category: 'defaultHotKeys',
25-
action: 'alt+right',
26-
name: 'skipForward',
23+
self.props.handleAnalyticsEvents({
24+
category: 'defaultHotKeys',
25+
action: 'alt+right',
26+
name: 'skipForward',
2727
value: 'na'
2828
});
2929

@@ -32,13 +32,13 @@ function returnHotKeys(self) {
3232
},
3333
'shift+left': {
3434
priority: 1,
35-
handler: () => {
36-
self.skipBackward();
35+
handler: () => {
36+
self.skipBackward();
3737

38-
self.props.handleAnalyticsEvents({
39-
category: 'defaultHotKeys',
40-
action: 'alt+left',
41-
name: 'skipBackward',
38+
self.props.handleAnalyticsEvents({
39+
category: 'defaultHotKeys',
40+
action: 'alt+left',
41+
name: 'skipBackward',
4242
value: 'na'
4343
});
4444

@@ -47,13 +47,13 @@ function returnHotKeys(self) {
4747
},
4848
'shift+down': {
4949
priority: 1,
50-
handler: () => {
51-
self.decreasePlaybackRate();
50+
handler: () => {
51+
self.decreasePlaybackRate();
5252

53-
self.props.handleAnalyticsEvents({
54-
category: 'defaultHotKeys',
55-
action: 'command+down',
56-
name: 'decreasePlaybackRate',
53+
self.props.handleAnalyticsEvents({
54+
category: 'defaultHotKeys',
55+
action: 'command+down',
56+
name: 'decreasePlaybackRate',
5757
value: 'na'
5858
});
5959

@@ -62,13 +62,13 @@ function returnHotKeys(self) {
6262
},
6363
'shift+up': {
6464
priority: 1,
65-
handler: () => {
66-
self.increasePlaybackRate();
65+
handler: () => {
66+
self.increasePlaybackRate();
6767

68-
self.props.handleAnalyticsEvents({
69-
category: 'defaultHotKeys',
70-
action: 'command+up',
71-
name: 'increasePlaybackRate',
68+
self.props.handleAnalyticsEvents({
69+
category: 'defaultHotKeys',
70+
action: 'command+up',
71+
name: 'increasePlaybackRate',
7272
value: 'na'
7373
});
7474

@@ -77,13 +77,13 @@ function returnHotKeys(self) {
7777
},
7878
'alt+shift+left': {
7979
priority: 1,
80-
handler: () => {
81-
self.rollBack();
82-
83-
self.props.handleAnalyticsEvents({
84-
category: 'defaultHotKeys',
85-
action: 'command+left',
86-
name: 'rollBack',
80+
handler: () => {
81+
self.rollBack();
82+
83+
self.props.handleAnalyticsEvents({
84+
category: 'defaultHotKeys',
85+
action: 'command+left',
86+
name: 'rollBack',
8787
value: 'na'
8888
});
8989

@@ -92,13 +92,13 @@ function returnHotKeys(self) {
9292
},
9393
'alt+k': {
9494
priority: 1,
95-
handler: () => {
95+
handler: () => {
9696
self.promptSetCurrentTime();
97-
98-
self.props.handleAnalyticsEvents({
99-
category: 'defaultHotKeys',
100-
action: 'alt+k',
101-
name: 'promptSetCurrentTime',
97+
98+
self.props.handleAnalyticsEvents({
99+
category: 'defaultHotKeys',
100+
action: 'alt+k',
101+
name: 'promptSetCurrentTime',
102102
value: 'na'
103103
});
104104

src/lib/TranscriptEditor/Settings/Shortcuts.module.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141

4242
.shortcut {
4343
display: inline-block;
44-
min-width: 4em;
44+
width: 7em;
4545
background: color-labs-red;
4646
font-weight: lighter;
4747
color: white;

src/lib/TranscriptEditor/Settings/TimecodeOffset/index.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ class TimecodeOffset extends React.Component {
2323
resetTimecodeOffset = () => {
2424
const resetTimecodeOffsetValue = 0;
2525

26-
this.props.handleAnalyticsEvents({
27-
category: 'TimecodeOffset',
28-
action: 'resetTimecodeOffset',
29-
name: 'resetTimecodeOffset',
26+
this.props.handleAnalyticsEvents({
27+
category: 'TimecodeOffset',
28+
action: 'resetTimecodeOffset',
29+
name: 'resetTimecodeOffset',
3030
value: 0
3131
});
3232

@@ -38,10 +38,10 @@ class TimecodeOffset extends React.Component {
3838
}
3939

4040
setTimecodeOffset = () => {
41-
this.props.handleAnalyticsEvents({
42-
category: 'TimecodeOffset',
43-
action: 'setTimecodeOffset',
44-
name: 'setTimecodeOffset',
41+
this.props.handleAnalyticsEvents({
42+
category: 'TimecodeOffset',
43+
action: 'setTimecodeOffset',
44+
name: 'setTimecodeOffset',
4545
value: this.state.timecodeOffset
4646
});
4747

src/lib/TranscriptEditor/Settings/TimecodeOffset/index.module.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,5 @@
1616
.button {
1717
font-weight: lighter;
1818
font-size: 0.8em;
19+
cursor: pointer;
1920
}

src/lib/TranscriptEditor/TimedTextEditor/Word.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ class Word extends PureComponent {
55
generateConfidence = (data) => {
66
// handling edge case where confidence score not present
77
if (data.confidence) {
8-
return data.confidence > 0.6 ? 'high' : 'low';
8+
return data.confidence > 0.6 ? 'high' : 'low';
99
}
1010

1111
return 'high';

0 commit comments

Comments
 (0)