Skip to content

Fast forward/rewind - bug #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pietrop opened this issue Nov 19, 2018 · 1 comment
Closed

Fast forward/rewind - bug #14

pietrop opened this issue Nov 19, 2018 · 1 comment
Labels
bug Something isn't working Feature New feature that is going to be implemented

Comments

@pietrop
Copy link
Contributor

pietrop commented Nov 19, 2018 •
edited
Loading

Describe the bug
Expecting Fast forward/rewind button to keep fast forwarding or rewinding if user keeps pressed.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://bbc.github.io/react-transcript-editor
  2. Click on Load Demo
  3. Click on ▶▶ and keep pressed on it
  4. See error - does not skip forward until you release

Expected behavior
if you keep pressed it should continue to skip forward (eg 10 sec increment) until you release, then it should stop

Screenshots
NA

Desktop (please complete the following information):

  • OS: Mac Os X High Sierrra
  • Browser : Chrome
  • Version: Version 70.0.3538.102 (Official Build) (64-bit)

Additional context
Might need the use of a timer to detect that the key is still pressed?

Note, that this works fine when calling fast forward/rewind with keyboard shortcuts.
@pietrop pietrop added the bug Something isn't working label Nov 19, 2018
@pietrop pietrop changed the title Fast forward/rewind Fast forward/rewind - bug Nov 19, 2018
@pietrop pietrop added the Feature New feature that is going to be implemented label Nov 22, 2018
@pietrop pietrop mentioned this issue Nov 23, 2018
Merged
@pietrop
Copy link
Contributor Author

pietrop commented Nov 23, 2018

being addressed in this PR #22

@pietrop pietrop closed this as completed Nov 23, 2018
@pietrop pietrop mentioned this issue Dec 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Feature New feature that is going to be implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pietrop