Maximum call stack size exceeded

[donaldpipowitch]

Try to compileFromFile this schema throws.

/Users/foo/webpack/node_modules/lodash/lodash.js:2591
    function baseClone(value, isDeep, isFull, customizer, key, object, stack) {
                      ^

RangeError: Maximum call stack size exceeded
    at baseClone (/Users/foo/webpack/node_modules/lodash/lodash.js:2591:23)
    at /Users/foo/webpack/node_modules/lodash/lodash.js:2644:34
    at arrayEach (/Users/foo/webpack/node_modules/lodash/lodash.js:520:11)
    at baseClone (/Users/foo/webpack/node_modules/lodash/lodash.js:2638:7)
    at baseMergeDeep (/Users/foo/webpack/node_modules/lodash/lodash.js:3627:24)
    at /Users/foo/webpack/node_modules/lodash/lodash.js:3562:11
    at arrayEach (/Users/foo/webpack/node_modules/lodash/lodash.js:520:11)
    at baseMerge (/Users/foo/webpack/node_modules/lodash/lodash.js:3555:7)
    at /Users/foo/webpack/node_modules/lodash/lodash.js:13254:7
    at Function.<anonymous> (/Users/foo/webpack/node_modules/lodash/lodash.js:4781:13)

The webpack schema is quite heavy. Perfect stress test to optimize ;) Note that you have to delete this enum because of #34 to get this working for now.

[darcyparker]

An initial guess: https://github.com/bcherny/json-schema-to-typescript/blob/master/src/index.ts#L313 because merge() uses baseClone().

• merge calls baseMergeDeep
• baseMergeDeep calls baseClone and baseClone() is recursive with a warning about stack limits because of its recurssive nature.
• And there is a bit more recursion in baseMergeDeep().

Is the full stack trace shown above? I didn't attempt to reproduce... but made this guess by looking for recursive lodash methods used by this project. My guess is https://github.com/bcherny/json-schema-to-typescript/blob/master/src/index.ts#L313 is in the stack trace.

I don't have time to look at this further today... and may not in next few days. But wanted to share my initial findings. I think https://github.com/bcherny/json-schema-to-typescript/blob/master/src/index.ts#L313 can be refactored to not use lodash and this may solve the problem.

[donaldpipowitch]

Is the full stack trace shown above?

Yes.

[darcyparker]

FYI: I have a test in place that blows the stack. darcyparker@db2b30c

[darcyparker]

Updating link for line with merge() that I mentioned above because new commits changed the line number:

json-schema-to-typescript/src/index.ts

Line 274 in 1aa7317

const copy = merge({}, Compiler.DEFAULT_SCHEMA, schema)

(This link points to a specific commit's file's line number)

[darcyparker]

A WIP that improves call stack usage is available for review. Please let me know if it helps.

[bcherny]

@donaldpipowitch You're getting a call stack exceeded error because you have a bunch of circular references in your schema

• https://github.com/webpack/webpack/blob/e5ae047334d187b5fe17318fbc5ef58f6e500419/schemas/webpackOptionsSchema.json#L655
• https://github.com/webpack/webpack/blob/e5ae047334d187b5fe17318fbc5ef58f6e500419/schemas/webpackOptionsSchema.json#L706
• https://github.com/webpack/webpack/blob/e5ae047334d187b5fe17318fbc5ef58f6e500419/schemas/webpackOptionsSchema.json#L729
  etc

I'll add a circular reference checker to the ref resolver (the resolver is very bare bones as is). In the meantime, if you get rid of the circular references, your schema seems to compile fine.

[donaldpipowitch]

Thank you both. I'll close this issue than as it is probably a problem with the schema and its circular references.

[donaldpipowitch]

Short question: Is this really a circular reference? Doesn't this point to this definition?

[darcyparker]

Side question: Do you know of a tool that generates a graph of a json schema? (For example something that creates graphml for http://www.yworks.com/products/yed or http://www.cytoscape.org/, or alternatively dot files for http://graphviz.org/ dot) If not, I am thinking this could be an interesting project. It's one thing to write circular reference detection and give feedback when you walk to a node that you've been to before... but visually seeing it in a picture could be helpful.

[bcherny]

@donaldpipowitch You're right - I misread the schema. This issue is with resolving local $refs, not with a circular definition. Filed #44

@darcyparker Not off the top of my head, but it would be pretty trivial to write one I think.