Add pre-dereference normalization for annotation siblings in files#683
Open
LudaThomas wants to merge 2 commits into
Open
Add pre-dereference normalization for annotation siblings in files#683LudaThomas wants to merge 2 commits into
LudaThomas wants to merge 2 commits into
Conversation
…rc/resolver.ts
The lift transform only ran on the root input schema, so sibling- annotated inside files loaded by json-schema-ref-parser still merged and produced suffixed duplicates (Range2, Hyperparameters1, etc.) when the root schema 'd across files. Wrap the JSON and YAML parser plugins so the transform runs on every loaded file as it's parsed.
|
@LudaThomas, I just want to say "thank you". Even if the PR won't be merged, it's clear how to modify the JSON schema to avoid this problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
// JSON Schema 2019-09 allows annotation siblings next to
$ref. When such// siblings are present, json-schema-ref-parser produces a fresh merged object
// for the
$ref, which breaks the referential equality the parser relies on// to emit a named reference instead of inlining the target type. By wrapping
// the
$refin a single-memberallOfbefore dereferencing, the dereferenced// pointer keeps its identity and the annotations remain on the wrapper, where
// they can attach as a property-level JSDoc comment.
see #363