Merge pull request #179 from bcomnes/fix-star-matches

add tests for double stars

Author: bcomnes

lib/match-tasks.js

@@ -10,8 +10,7 @@
 // Requirements
 // ------------------------------------------------------------------------------
 
-const { minimatch } = require('minimatch')
-const Minimatch = minimatch.Minimatch
+const picomatch = require('picomatch')
 
 // ------------------------------------------------------------------------------
 // Helpers
@@ -21,7 +20,7 @@ const COLON_OR_SLASH = /[:/]/g
 const CONVERT_MAP = { ':': '/', '/': ':' }
 
 /**
- * Swaps ":" and "/", in order to use ":" as the separator in minimatch.
+ * Swaps ":" and "/", in order to use ":" as the separator in picomatch.
  *
  * @param {string} s - A text to swap.
  * @returns {string} The text which was swapped.
@@ -44,8 +43,10 @@ function createFilter (pattern) {
   const spacePos = trimmed.indexOf(' ')
   const task = spacePos < 0 ? trimmed : trimmed.slice(0, spacePos)
   const args = spacePos < 0 ? '' : trimmed.slice(spacePos)
-  const matcher = new Minimatch(swapColonAndSlash(task), { nonegate: true })
-  const match = matcher.match.bind(matcher)
+  const match = picomatch(swapColonAndSlash(task), {
+    nonegate: true,
+    strictSlashes: true,
+  })
 
   return { match, task, args }
 }

package.json

@@ -34,7 +34,7 @@
     "ansi-styles": "^6.2.1",
     "cross-spawn": "^7.0.6",
     "memorystream": "^0.3.1",
-    "minimatch": "^10.0.1",
+    "picomatch": "^4.0.2",
     "pidtree": "^0.6.0",
     "read-package-json-fast": "^4.0.0",
     "shell-quote": "^1.7.3",

test/pattern.js

@@ -50,6 +50,24 @@ describe('[pattern] it should run matched tasks if glob like patterns are given.
     })
   })
 
+  describe('"test-task:append:**" to "test-task:append:a", "test-task:append:a:c", "test-task:append:a:d", and "test-task:append:b"', () => {
+    it('Node API', async () => {
+      await nodeApi('test-task:append:**')
+      assert(result() === 'aaacacadadbb')
+    })
+
+    it('npm-run-all command', async () => {
+      await runAll(['test-task:append:**'])
+      assert(result() === 'aaacacadadbb')
+    })
+
+    it('run-s command', async () => {
+      await runSeq(['test-task:append:**'])
+      assert(result() === 'aaacacadadbb')
+    })
+  })
+
+  // should act same way as section above
   describe('"test-task:append:**:*" to "test-task:append:a", "test-task:append:a:c", "test-task:append:a:d", and "test-task:append:b"', () => {
     it('Node API', async () => {
       await nodeApi('test-task:append:**:*')