Move color filter absorption to a new method

Author: bdero

impeller/aiks/canvas.cc

@@ -330,12 +330,7 @@ bool Canvas::AttemptDrawBlurredRRect(const Rect& rect,
   Paint rrect_paint = paint;
 
   // Absorb the color filter, if any.
-  if (rrect_paint.HasColorFilter()) {
-    rrect_paint.color =
-        rrect_paint.GetColorFilter()->GetCPUColorFilterProc()(paint.color);
-    rrect_paint.color_filter = nullptr;
-    rrect_paint.invert_colors = false;
-  }
+  rrect_paint.AbsorbColorFilterIntoColor();
 
   // In some cases, we need to render the mask blur to a separate layer.
   //

impeller/aiks/paint.cc

@@ -199,4 +199,20 @@ bool Paint::HasColorFilter() const {
   return !!color_filter || invert_colors;
 }
 
+void Paint::AbsorbColorFilterIntoColor() {
+  // This method should only ever be used when the caller knows that the color
+  // source is a solid color. This is not a valid way to apply the color filter
+  // for other color sources.
+  FML_DCHECK(color_source.GetType() == ColorSource::Type::kColor);
+
+  std::shared_ptr<ColorFilter> final_color_filter = GetColorFilter();
+  if (!final_color_filter) {
+    return;  // Nothing to absorb.
+  }
+
+  color = GetColorFilter()->GetCPUColorFilterProc()(color);
+  color_filter = nullptr;
+  invert_colors = false;
+}
+
 }  // namespace impeller

impeller/aiks/paint.h

@@ -104,6 +104,15 @@ struct Paint {
       std::shared_ptr<Contents> input,
       ColorFilterContents::AbsorbOpacity absorb_opacity =
           ColorFilterContents::AbsorbOpacity::kNo) const;
+
+  /// @brief      Absorbs the color filter (if any) into the Paint's color.
+  ///             There are multiple paint attributes that can result in a
+  ///             filter being applied.
+  ///             This is only valid if the color source is set is a solid
+  ///             color.
+  void AbsorbColorFilterIntoColor();
+
+  friend class Canvas;
 };
 
 }  // namespace impeller