Reworking how xml is parsed so that it can be formatted and preserve the original attribute vales and new lines (#1679)

closes #1610

Author: belav

.github/workflows/ValidatePullRequest.yml

@@ -15,6 +15,14 @@ jobs:
           --logger "GitHubActions;summary.includePassedTests=true;summary.includeSkippedTests=true"
           --
           RunConfiguration.CollectSourceInformation=true
+  no_warnings:
+    runs-on: ubuntu-latest
+    name: No Warnings
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-dotnet@v3
+      - run: >
+          dotnet build CSharpier.slnx -c release -p:TreatWarningsAsErrors=true
   builds_playground:
     runs-on: ubuntu-latest
     name: Builds Playground

.run/Debug msbuild.run.xml .run/Debug CLI.run.xml.run/Debug msbuild.run.xml renamed to .run/Debug CLI.run.xml

@@ -1,28 +1,23 @@
 <component name="ProjectRunConfigurationManager">
-  <configuration
-    default="false"
-    name="Debug msbuild"
-    type="DotNetProject"
-    factoryName=".NET Project"
-  >
+  <configuration default="false" name="Debug CLI" type="DotNetProject" factoryName=".NET Project">
     <option
       name="EXE_PATH"
-      value="$PROJECT_DIR$/Src/CSharpier.Cli/bin/Debug/net8.0/CSharpier.exe"
+      value="$PROJECT_DIR$/Src/CSharpier.Cli/bin/Debug/net8.0/CSharpier.dll"
     />
     <option
       name="PROGRAM_PARAMETERS"
-      value="check C:\projects\csharpier-msbuild --log-format MsBuild"
+      value="format C:\projects\csharpier-repos\mono\mcs\class\System.XML\Test\System.Xml\nist_dom\files\staff.xml"
     />
     <option name="WORKING_DIRECTORY" value="$PROJECT_DIR$/Src/CSharpier.Cli/bin/Debug/net8.0" />
     <option name="PASS_PARENT_ENVS" value="1" />
     <option name="USE_EXTERNAL_CONSOLE" value="0" />
     <option name="ENV_FILE_PATHS" value="" />
     <option name="REDIRECT_INPUT_PATH" value="" />
     <option name="PTY_MODE" value="Auto" />
+    <option name="MIXED_MODE_DEBUG" value="0" />
     <option name="USE_MONO" value="0" />
     <option name="RUNTIME_ARGUMENTS" value="" />
     <option name="AUTO_ATTACH_CHILDREN" value="0" />
-    <option name="MIXED_MODE_DEBUG" value="0" />
     <option name="PROJECT_PATH" value="$PROJECT_DIR$/Src/CSharpier.Cli/CSharpier.Cli.csproj" />
     <option name="PROJECT_EXE_PATH_TRACKING" value="1" />
     <option name="PROJECT_ARGUMENTS_TRACKING" value="1" />

.run/Playground.run.xml

@@ -9,7 +9,7 @@
       name="LAUNCH_PROFILE_PROJECT_FILE_PATH"
       value="$PROJECT_DIR$/Src/CSharpier.Playground/CSharpier.Playground.csproj"
     />
-    <option name="LAUNCH_PROFILE_TFM" value="net9.0" />
+    <option name="LAUNCH_PROFILE_TFM" value="net10.0" />
     <option name="LAUNCH_PROFILE_NAME" value="Watch" />
     <option name="USE_EXTERNAL_CONSOLE" value="0" />
     <option name="USE_MONO" value="0" />
@@ -18,6 +18,7 @@
     <option name="SHOW_IIS_EXPRESS_OUTPUT" value="0" />
     <option name="SEND_DEBUG_REQUEST" value="1" />
     <option name="ADDITIONAL_IIS_EXPRESS_ARGUMENTS" value="" />
+    <option name="AUTO_ATTACH_CHILDREN" value="0" />
     <method v="2">
       <option name="Build" />
     </method>

Directory.Build.props

@@ -6,7 +6,6 @@
     <Nullable>enable</Nullable>
     <!-- this is the warning generators get when they fail to generate a source file this makes sure the error for it failing is obvious -->
     <WarningsAsErrors>CS8032;CS8033;</WarningsAsErrors>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <EnableNETAnalyzers>true</EnableNETAnalyzers>
     <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
     <AnalysisMode>Recommended</AnalysisMode>

Shell/BuildProject.psm1

@@ -1,10 +1,14 @@
-function CSH-BuildProject
-{
+function CSH-BuildProject {
+    param (
+        [switch]$doNotExit = $false
+    )
+    
+    
     $repositoryRoot = Join-Path $PSScriptRoot ".."
     $csProjectPath = Join-Path $repositoryRoot "Src/CSharpier.Cli/CSharpier.Cli.csproj"
 
     & dotnet build $csProjectPath -c release
-    if ($lastExitCode -gt 0) {
+    if ($lastExitCode -gt 0 -and -not $doNotExit) {
         exit $lastExitCode;
     }
 }

Shell/ReviewBranch.psm1

@@ -2,7 +2,8 @@ function CSH-ReviewBranch {
     param (
         [string]$folder,
         [string]$pathToTestingRepo,
-        [switch]$skipValidation = $true
+        [switch]$skipValidation = $true,
+        [switch]$onlyXml = $false
     )
 
     $repositoryRoot = Join-Path $PSScriptRoot ".."
@@ -60,22 +61,25 @@ function CSH-ReviewBranch {
 
     if ($firstRun) {
         Set-Location $repositoryRoot
-#        try  {
-            & git checkout main #2>&1 | Out-String
-#        }
-#        catch {
-#            Write-Host "Could not checkout main on csharpier, working directory is probably not clean"
-#            return
-#        }
-        
-        CSH-BuildProject
+
+        & git checkout main #2>&1 | Out-String
+
+        CSH-BuildProject -doNotExit
+
+        if ($lastExitCode -gt 0) {
+            return
+        }
 
         Set-Location $pathToTestingRepo
 
         & git checkout main
         & git reset --hard
         & git checkout -b $preBranch
 
+        if ($onlyXml) {
+            Add-Content -Path "$pathToTestingRepo/.csharpierignore" -Value "**/*.cs"
+        }
+        
         dotnet $csharpierDllPath format . $skipValidationParam --no-cache
         # there is some weirdness with a couple files with #if where
         # they need to be formatted twice to get them stable