Skip to content

Commit 58f190d

Browse files
committed
Merge pull request #1257 from benoitc/fix/1256
unblock the wait loop under python 3.5
2 parents 9d158be + b0c0333 commit 58f190d

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

gunicorn/workers/base.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,8 @@ def changed(fname):
113113
[util.close_on_exec(s) for s in self.sockets]
114114
util.close_on_exec(self.tmp.fileno())
115115

116+
self.wait_fds = self.sockets + [self.PIPE[0]]
117+
116118
self.log.close_on_exec()
117119

118120
self.init_signals()
@@ -164,6 +166,9 @@ def init_signals(self):
164166
signal.siginterrupt(signal.SIGTERM, False)
165167
signal.siginterrupt(signal.SIGUSR1, False)
166168

169+
if hasattr(signal, 'set_wakeup_fd'):
170+
signal.set_wakeup_fd(self.PIPE[1])
171+
167172
def handle_usr1(self, sig, frame):
168173
self.log.reopen_files()
169174

gunicorn/workers/sync.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def accept(self, listener):
3232
def wait(self, timeout):
3333
try:
3434
self.notify()
35-
ret = select.select(self.sockets, [], self.PIPE, timeout)
35+
ret = select.select(self.wait_fds, [], [], timeout)
3636
if ret[0]:
3737
return ret[0]
3838

@@ -93,6 +93,9 @@ def run_for_multiple(self, timeout):
9393

9494
if ready is not None:
9595
for listener in ready:
96+
if listener == self.PIPE[0]:
97+
continue
98+
9699
try:
97100
self.accept(listener)
98101
except EnvironmentError as e:

0 commit comments

Comments
 (0)