Skip to content

Commit b58ca87

Browse files
committed
ci: Use Ubuntu 22.04 runner for run-examples, run-examples-on-wasm jobs (#6875)
# Objective - The `run-examples-on-wasm` job fails on Ubuntu 22.04, when it was previously working on Ubuntu 20.04. Playwright 1.22.1 (the version currently pinned by us) fails trying to install system dependencies that were renamed between Ubuntu 20.04 and 22.04. - The `run-examples` job previously failed on Ubuntu 22.04 with errors consistent with those listed in [this upstream mesa bug](https://gitlab.freedesktop.org/mesa/mesa/-/issues/7819). - Fixes #6832 ## Solution - Upgrade `playwright` to the latest [v1.28.1](https://github.com/microsoft/playwright/releases/tag/v1.28.1) release. Ubuntu 22.04 support was [added](microsoft/playwright#14588) in [v1.23.0](https://github.com/microsoft/playwright/releases/tag/v1.23.0). The [test now passes on 22.04](https://github.com/oliviacrain/bevy/actions/runs/3633583112/jobs/6130757397), and the output screenshots are unchanged from previous job outputs. - Use `ubuntu-latest` for the `run-examples` job. No other modifications necessary. The [PPA we pull mesa from](https://launchpad.net/~oibaf/+archive/ubuntu/graphics-drivers) rebuilt the package for 22.04 with the [upstream fix](https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20145/diffs?commit_id=b3d1ae19f2f4d93cf0a5f45a598149ac4e8e05aa).
1 parent 8eedc8f commit b58ca87

File tree

4 files changed

+32
-18
lines changed

4 files changed

+32
-18
lines changed

.github/start-wasm-example/package-lock.json

Lines changed: 29 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/start-wasm-example/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"author": "",
99
"license": "ISC",
1010
"devDependencies": {
11-
"@playwright/test": "^1.22.1"
11+
"@playwright/test": "^1.28.1"
1212
},
1313
"dependencies": {
1414
"dotenv": "^16.0.1"

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ jobs:
159159
#GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
160160

161161
run-examples:
162-
runs-on: ubuntu-20.04 # TODO: figure out why latest fails
162+
runs-on: ubuntu-latest
163163
timeout-minutes: 30
164164
steps:
165165
- name: Install Bevy dependencies

.github/workflows/validation-jobs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ jobs:
9191
done
9292
9393
run-examples-on-wasm:
94-
runs-on: ubuntu-20.04 # TODO: figure out why this fails on latest
94+
runs-on: ubuntu-latest
9595
timeout-minutes: 60
9696
steps:
9797
- uses: actions/checkout@v3

0 commit comments

Comments
 (0)