Skip to content

Commit d623731

Browse files
authored
Move event traces to detailed_trace! (#7732)
# Objective Noticed while writing #7728 that we are using `trace!` logs in our event functions. This has shown to have significant overhead, even trace level logs are disabled globally, as seen in #7639. ## Solution Use the `detailed_trace!` macro introduced in #7639. Also removed the `event_trace` function that was only used in one location. --- ## Changelog Changed: Event trace logs are now feature gated behind the `detailed-trace` feature.
1 parent 52ee83e commit d623731

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

crates/bevy_ecs/src/event.rs

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
33
use crate as bevy_ecs;
44
use crate::system::{Local, Res, ResMut, Resource, SystemParam};
5-
use bevy_utils::tracing::trace;
5+
use bevy_utils::detailed_trace;
66
use std::ops::{Deref, DerefMut};
77
use std::{fmt, hash::Hash, iter::Chain, marker::PhantomData, slice::Iter};
88
/// A type that can be stored in an [`Events<E>`] resource
@@ -419,10 +419,6 @@ pub struct ManualEventIteratorWithId<'a, E: Event> {
419419
unread: usize,
420420
}
421421

422-
fn event_trace<E: Event>(id: EventId<E>) {
423-
trace!("EventReader::iter() -> {}", id);
424-
}
425-
426422
impl<'a, E: Event> ManualEventIteratorWithId<'a, E> {
427423
pub fn new(reader: &'a mut ManualEventReader<E>, events: &'a Events<E>) -> Self {
428424
let a_index = (reader.last_event_count).saturating_sub(events.events_a.start_event_count);
@@ -459,7 +455,7 @@ impl<'a, E: Event> Iterator for ManualEventIteratorWithId<'a, E> {
459455
.map(|instance| (&instance.event, instance.event_id))
460456
{
461457
Some(item) => {
462-
event_trace(item.1);
458+
detailed_trace!("EventReader::iter() -> {}", item.1);
463459
self.reader.last_event_count += 1;
464460
self.unread -= 1;
465461
Some(item)
@@ -513,7 +509,7 @@ impl<E: Event> Events<E> {
513509
id: self.event_count,
514510
_marker: PhantomData,
515511
};
516-
trace!("Events::send() -> id: {}", event_id);
512+
detailed_trace!("Events::send() -> id: {}", event_id);
517513

518514
let event_instance = EventInstance { event_id, event };
519515

@@ -654,7 +650,7 @@ impl<E: Event> std::iter::Extend<E> for Events<E> {
654650
self.events_b.extend(events);
655651

656652
if old_count != event_count {
657-
trace!(
653+
detailed_trace!(
658654
"Events::extend() -> ids: ({}..{})",
659655
self.event_count,
660656
event_count

0 commit comments

Comments
 (0)