Skip to content
This repository was archived by the owner on Feb 7, 2024. It is now read-only.

Statistics logging not working in docker environment #114

Closed
francislavoie opened this issue Feb 21, 2019 · 4 comments · Fixed by #115
Closed

Statistics logging not working in docker environment #114

francislavoie opened this issue Feb 21, 2019 · 4 comments · Fixed by #115

Comments

@francislavoie
Copy link
Contributor

The fix in #31, i.e. DNS resolver, doesn't solve the issue for me.

The problem is that action() is used in HttpStatisticsLogger to push the stats. This is an issue for me, because the URL for HTTP is different for internal services than external users. Since the websockets server is running in its own container, I need it to reach out directly to my webserver container for it to work.

In this case, I have a websockets container and a caddy container, so I need HttpStatisticsLogger to make requests to http://caddy or whatever that IP resolves to (using Docker's DNS resolver).

Should we add an config('url') override as a config option? I think that might be the simplest way to solve this. I don't think it's a correct assumption that APP_URL will always allow a backend service to connect to itself.

@pactode
Copy link

pactode commented Apr 9, 2019

Any updates on this? I have the same issue.

@francislavoie
Copy link
Contributor Author

See #115, I wrote a simple implementation. We're stuck waiting until the project maintainers take a look at the open PRs.

In the meantime, you could just make your own fork with those changes if you urgently need them (or directly edit the code in vendor/ but that's a very temporary solution)

@pactode
Copy link

pactode commented Apr 9, 2019

@francislavoie Thanks. I want to push for a more permanent solution, so I'll support your PR.

@francislavoie
Copy link
Contributor Author

@canhkieu this is not resolved, the PR is not merged. Why are you closing so many issues today?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants