Replies: 2 comments
-
I think this one should be implemented, we would likely flag this on code review to be changed so we might as well add a sniff for it. |
Beta Was this translation helpful? Give feedback.
0 replies
-
I think this would be a great addition. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Our string concatenation rules only currently check whether there is an appropriate amount of whitespace around the operator (i.e. 1 space before and after the
.
). We do not currently test beyond that, so the following code is considered valid:I would argue that this is incorrect; I would expect the above code to be considered valid only if it was formatted as per the one of the examples below:
Would it be valuable to folks if we added a Sniff for this style of concatenation, or are we happy to rely upon code review?
Beta Was this translation helpful? Give feedback.
All reactions