remove configurability via env variables

* this does not play well with compilation caches
* also we remove the only dependency we have

Author: darwin

docs/configuration.md

@@ -6,8 +6,7 @@ Configuration can be done on multiple levels (later overrides former levels):
 
 1. defaults
 2. compiler options
-3. environmental variables
-4. programmatically
+3. programmatically
 
 ### Configuration via defaults
 
@@ -37,22 +36,6 @@ For example:
 This overrides default `:features-to-install`, sets custom `:fn-symbol` and instructs cljs-devtools to print overridden config 
 values during installation.
 
-### Configuration via environmental variables
-
-We use [binaryage/env-config](https://github.com/binaryage/env-config) library to allow configuration overrides via 
-environmental variables. Common prefix for our configuration variables is `CLJS_DEVTOOLS`.
-
-For example, in a Bash shell you can do this to achieve configuration matching the config map above:
-
-    lein clean
-    env CLJS_DEVTOOLS/FN_SYMBOL=F \
-      CLJS_DEVTOOLS/PRINT_CONFIG_OVERRIDES=true \
-      CLJS_DEVTOOLS/FEATURES_TO_INSTALL="~[:formatters :hints]" \
-      lein cljsbuild once
-
-Please note that environmental variables are retrieved during compilation in a macro expansion. So proper environment must 
-be present during ClojureScript compilation and you have to clear compilation caches after changing the environment.
-
 ### Programmatic configuration
 
 When [installed manually](https://github.com/binaryage/cljs-devtools/blob/master/docs/installation.md#install-it-manually), 

project.clj

@@ -10,8 +10,7 @@
         :url  "https://github.com/binaryage/cljs-devtools"}
 
   :dependencies [[org.clojure/clojure "1.10.1" :scope "provided"]
-                 [org.clojure/clojurescript ~clojurescript-version :scope "provided"]
-                 [binaryage/env-config "0.2.2"]]
+                 [org.clojure/clojurescript ~clojurescript-version :scope "provided"]]
 
   :clean-targets ^{:protect false} ["target"
                                     "test/resources/.compiled"]
@@ -60,19 +59,6 @@
                                                         :preloads       [devtools.testenv]
                                                         :optimizations  :none
                                                         :checked-arrays :warn}}
-                                        :tests-with-config
-                                        {:source-paths ["src/lib"
-                                                        "test/src/tests"]
-                                         :compiler     {:output-to       "test/resources/.compiled/tests-with-config/build.js"
-                                                        :output-dir      "test/resources/.compiled/tests-with-config"
-                                                        :asset-path      ".compiled/tests-with-config"
-                                                        :main            devtools.main
-                                                        :optimizations   :none
-                                                        :checked-arrays  :warn
-                                                        :external-config {:devtools/config {:features-to-install    [:hints]
-                                                                                            :fn-symbol              "F"
-                                                                                            :print-config-overrides true}}
-                                                        :preloads        [devtools.testenv devtools.preload]}}                ; CLJS-1688
                                         :dead-code
                                         {:source-paths ["src/lib"
                                                         "test/src/dead-code"]
@@ -171,7 +157,6 @@
   :aliases {"test"                                ["do"
                                                    ["clean"]
                                                    ["test-tests"]
-                                                   ["test-tests-with-config"]
                                                    ["test-dead-code"]
                                                    ;["test-dce-size"]
                                                    ["test-advanced-warning"]]

scripts/compile-tests-with-config.sh

@@ -1,6 +1,5 @@
 (ns devtools.prefs
-  (:require [env-config.core :as env-config]
-            [cljs.env]))
+  (:require [cljs.env]))
 
 ; see https://github.com/binaryage/cljs-devtools/blob/master/docs/configuration.md
 
@@ -17,25 +16,15 @@
 
 ; -- environmental config ---------------------------------------------------------------------------------------------------
 
-(def ^:dynamic env-config-prefix "cljs-devtools")
-
 (defn get-env-vars []
   (-> {}
       (into (System/getenv))
       (into (System/getProperties))))
 
-(defn read-env-config []
-  (env-config/make-config-with-logging env-config-prefix (get-env-vars)))
-
-(def memoized-read-env-config (memoize read-env-config))
-
-(defmacro emit-env-config []
-  `'~(or (memoized-read-env-config) {}))
-
 ; -- macro config api -------------------------------------------------------------------------------------------------------
 
 (defn read-config []
-  (merge (memoized-read-env-config) (read-external-config)))
+  (read-external-config))
 
 (def memoized-read-config (memoize read-config))
 

src/lib/devtools/prefs.clj

@@ -1,12 +1,11 @@
 (ns devtools.prefs
-  (:require-macros [devtools.prefs :refer [emit-external-config emit-env-config]])
+  (:require-macros [devtools.prefs :refer [emit-external-config]])
   (:require [devtools.defaults :as defaults]))
 
 ; we use delay for DCE, see https://github.com/binaryage/cljs-devtools/issues/37
 (def default-config (delay @defaults/config))
 (def external-config (delay (emit-external-config)))
-(def env-config (delay (emit-env-config)))
-(def initial-config (delay (merge @default-config @external-config @env-config)))
+(def initial-config (delay (merge @default-config @external-config)))
 
 (def ^:dynamic *current-config* (delay @initial-config))