feat(analyze): implement noSyncScripts (#8108)

Author: Netail

.changeset/icy-bags-sleep.md

@@ -0,0 +1,18 @@
+---
+"@biomejs/biome": patch
+---
+
+Added the nursery rule [`noSyncScripts`](https://biomejs.dev/linter/rules/no-sync-scripts/). Prevent the usage of synchronous scripts.
+
+**Invalid:**
+
+```jsx
+<script src="https://third-party-script.js" />
+```
+
+**Valid:**
+
+```jsx
+<script src="https://third-party-script.js" async />
+<script src="https://third-party-script.js" defer />
+```

crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs

@@ -181,6 +181,7 @@ define_categories! {
     "lint/nursery/noParametersOnlyUsedInRecursion": "https://biomejs.dev/linter/rules/no-parameters-only-used-in-recursion",
     "lint/nursery/noReactForwardRef": "https://biomejs.dev/linter/rules/no-react-forward-ref",
     "lint/nursery/noShadow": "https://biomejs.dev/linter/rules/no-shadow",
+    "lint/nursery/noSyncScripts": "https://biomejs.dev/linter/rules/no-sync-scripts",
     "lint/nursery/noUnknownAttribute": "https://biomejs.dev/linter/rules/no-unknown-attribute",
     "lint/nursery/noUnnecessaryConditions": "https://biomejs.dev/linter/rules/no-unnecessary-conditions",
     "lint/nursery/noUnresolvedImports": "https://biomejs.dev/linter/rules/no-unresolved-imports",

crates/biome_configuration/src/analyzer/linter/rules.rs

@@ -3,10 +3,11 @@
 //! Generated file, do not edit by hand, see `xtask/codegen`
 
 use biome_analyze::declare_lint_group;
+pub mod no_sync_scripts;
 pub mod use_vue_valid_v_bind;
 pub mod use_vue_valid_v_else;
 pub mod use_vue_valid_v_else_if;
 pub mod use_vue_valid_v_html;
 pub mod use_vue_valid_v_if;
 pub mod use_vue_valid_v_on;
-declare_lint_group! { pub Nursery { name : "nursery" , rules : [self :: use_vue_valid_v_bind :: UseVueValidVBind , self :: use_vue_valid_v_else :: UseVueValidVElse , self :: use_vue_valid_v_else_if :: UseVueValidVElseIf , self :: use_vue_valid_v_html :: UseVueValidVHtml , self :: use_vue_valid_v_if :: UseVueValidVIf , self :: use_vue_valid_v_on :: UseVueValidVOn ,] } }
+declare_lint_group! { pub Nursery { name : "nursery" , rules : [self :: no_sync_scripts :: NoSyncScripts , self :: use_vue_valid_v_bind :: UseVueValidVBind , self :: use_vue_valid_v_else :: UseVueValidVElse , self :: use_vue_valid_v_else_if :: UseVueValidVElseIf , self :: use_vue_valid_v_html :: UseVueValidVHtml , self :: use_vue_valid_v_if :: UseVueValidVIf , self :: use_vue_valid_v_on :: UseVueValidVOn ,] } }

crates/biome_configuration/src/generated/domain_selector.rs

@@ -0,0 +1,79 @@
+use biome_analyze::{
+    Ast, Rule, RuleDiagnostic, RuleSource, context::RuleContext, declare_lint_rule,
+};
+use biome_console::markup;
+use biome_html_syntax::HtmlOpeningElement;
+use biome_rowan::AstNode;
+use biome_rule_options::no_sync_scripts::NoSyncScriptsOptions;
+
+declare_lint_rule! {
+    /// Prevent the usage of synchronous scripts.
+    ///
+    /// A synchronous script can impact your webpage performance, read more on how to [Efficiently load third-party JavaScript](https://web.dev/articles/efficiently-load-third-party-javascript).
+    ///
+    /// ## Examples
+    ///
+    /// ### Invalid
+    ///
+    /// ```html,expect_diagnostic
+    /// <script src=""></script>
+    /// ```
+    ///
+    /// ### Valid
+    ///
+    /// ```html
+    /// <script src="" async></script>
+    /// <script src="" defer></script>
+    /// ```
+    ///
+    pub NoSyncScripts {
+        version: "next",
+        name: "noSyncScripts",
+        language: "html",
+        recommended: false,
+        sources: &[RuleSource::EslintNext("no-sync-scripts").same()],
+    }
+}
+
+impl Rule for NoSyncScripts {
+    type Query = Ast<HtmlOpeningElement>;
+    type State = ();
+    type Signals = Option<Self::State>;
+    type Options = NoSyncScriptsOptions;
+
+    fn run(ctx: &RuleContext<Self>) -> Option<Self::State> {
+        let binding = ctx.query();
+
+        let name = binding.name().ok()?;
+        let value_token = name.value_token().ok()?;
+        if value_token.text_trimmed() != "script" {
+            return None;
+        }
+
+        let attributes = binding.attributes();
+        if attributes.find_by_name("src").is_none()
+            || attributes.find_by_name("async").is_some()
+            || attributes.find_by_name("defer").is_some()
+        {
+            return None;
+        }
+
+        Some(())
+    }
+
+    fn diagnostic(ctx: &RuleContext<Self>, _state: &Self::State) -> Option<RuleDiagnostic> {
+        let node = ctx.query();
+        Some(
+            RuleDiagnostic::new(
+                rule_category!(),
+                node.range(),
+                markup! {
+                    "Unexpected synchronous script."
+                },
+            )
+            .note(markup! {
+                "Synchronous scripts can impact your webpage performance. Add the \"async\" or \"defer\" attribute."
+            }),
+        )
+    }
+}

crates/biome_diagnostics_categories/src/categories.rs

@@ -0,0 +1 @@
+<script src=""></script>

crates/biome_html_analyze/src/lint/nursery.rs

@@ -0,0 +1,24 @@
+---
+source: crates/biome_html_analyze/tests/spec_tests.rs
+expression: invalid.html
+---
+# Input
+```html
+<script src=""></script>
+
+```
+
+# Diagnostics
+```
+invalid.html:1:1 lint/nursery/noSyncScripts ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  i Unexpected synchronous script.
+  
+  > 1 │ <script src=""></script>
+      │ ^^^^^^^^^^^^^^^
+    2 │ 
+  
+  i Synchronous scripts can impact your webpage performance. Add the "async" or "defer" attribute.
+  
+
+```

crates/biome_html_analyze/src/lint/nursery/no_sync_scripts.rs

@@ -0,0 +1,8 @@
+/* should not generate diagnostics */
+<noscript></noscript>
+
+<script></script>
+
+<script src="" async></script>
+
+<script src="" defer></script>