fix(schema): domains and feature kind (#8147)

Author: ematipico

crates/biome_configuration/src/analyzer/linter/mod.rs

@@ -74,10 +74,10 @@ impl schemars::JsonSchema for RuleDomains {
         schemars::json_schema!({
             "type": "object",
             "propertyNames": {
-                "$ref": "#/components/schemas/RuleDomain"
+                "$ref": "#/$defs/RuleDomain"
             },
             "additionalProperties": {
-                "$ref": "#/components/schemas/RuleDomainValue"
+                "$ref": "#/$defs/RuleDomainValue"
             }
         })
     }

crates/biome_service/src/workspace.rs

@@ -434,10 +434,10 @@ impl schemars::JsonSchema for FeaturesSupported {
         schemars::json_schema!({
             "type": "object",
             "propertyNames": {
-                "$ref": "#/components/schemas/FeatureKind"
+                "$ref": "#/$defs/FeatureKind"
             },
             "additionalProperties": {
-                "$ref": "#/components/schemas/SupportKind"
+                "$ref": "#/$defs/SupportKind"
             }
         })
     }

crates/biome_service/src/workspace_types.rs

@@ -727,8 +727,8 @@ impl WorkspaceMethod {
         P: JsonSchema,
         R: JsonSchema,
     {
-        let params = SchemaGenerator::from(SchemaSettings::openapi3()).root_schema_for::<P>();
-        let result = SchemaGenerator::from(SchemaSettings::openapi3()).root_schema_for::<R>();
+        let params = SchemaGenerator::from(SchemaSettings::draft2019_09()).root_schema_for::<P>();
+        let result = SchemaGenerator::from(SchemaSettings::draft2019_09()).root_schema_for::<R>();
         Self {
             name,
             params,

crates/biome_wasm/build.rs

@@ -7,7 +7,6 @@ use biome_js_formatter::{context::JsFormatOptions, format_node};
 use biome_rowan::AstNode;
 use biome_service::workspace_types::{ModuleQueue, generate_type, methods};
 use quote::{format_ident, quote};
-use schemars::generate::{SchemaGenerator, SchemaSettings};
 use std::{env, fs, io, path::PathBuf};
 
 fn main() -> io::Result<()> {
@@ -21,11 +20,6 @@ fn main() -> io::Result<()> {
         generate_type(&mut items, &mut queue, &method.params);
         generate_type(&mut items, &mut queue, &method.result);
     }
-    // HACK: SupportKind doesn't get picked up in the loop above, so we add it manually
-    let support_kind_schema = SchemaGenerator::from(SchemaSettings::openapi3())
-        .root_schema_for::<biome_service::workspace::SupportKind>();
-
-    generate_type(&mut items, &mut queue, &support_kind_schema);
 
     let module = make::js_module(
         make::js_directive_list(None),

justfile

@@ -27,12 +27,16 @@ gen-all:
 
 # Generates TypeScript types and JSON schema of the configuration
 gen-bindings:
-  cargo codegen-schema
+  just gen-schema
   just gen-types
 
+# Generates TypeScript types
 gen-types:
   cargo run -p xtask_codegen --features schema -- bindings
 
+# Generates the JSON Schema of the configuration
+gen-schema:
+  cargo codegen-schema
 
 # Generates code generated files for the linter
 gen-analyzer:

packages/@biomejs/biome/configuration_schema.json

@@ -10,7 +10,6 @@ use biome_js_syntax::{
 use biome_rowan::AstNode;
 use biome_service::workspace_types::{ModuleQueue, generate_type, methods};
 use biome_string_case::Case;
-use schemars::{SchemaGenerator, generate::SchemaSettings};
 use xtask_codegen::update;
 use xtask_glue::{Mode, Result, project_root};
 
@@ -154,17 +153,6 @@ pub(crate) fn generate_workspace_bindings(mode: Mode) -> Result<()> {
             .build(),
         ));
     }
-    // HACK: these types doesn't get picked up in the loop above, so we add it manually
-    let support_kind_schema = SchemaGenerator::from(SchemaSettings::openapi3())
-        .root_schema_for::<biome_service::workspace::SupportKind>();
-    generate_type(&mut declarations, &mut queue, &support_kind_schema);
-    let rule_domain_schema = SchemaGenerator::from(SchemaSettings::openapi3())
-        .root_schema_for::<biome_analyze::RuleDomain>();
-    generate_type(&mut declarations, &mut queue, &rule_domain_schema);
-    let rule_domain_value_schema = SchemaGenerator::from(SchemaSettings::openapi3())
-        .root_schema_for::<biome_configuration::analyzer::RuleDomainValue>(
-    );
-    generate_type(&mut declarations, &mut queue, &rule_domain_value_schema);
 
     let leading_comment = [
         (