feat(cli): rdjson reporter (#7698)

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Author: ematipico

.changeset/eager-suns-smoke.md

@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed an issue where the JUnit reporter returned a zero-based location. Now the location returned is one-based.

.changeset/gentle-pots-hunt.md

@@ -0,0 +1,64 @@
+---
+"@biomejs/biome": minor
+---
+
+Added a new reporter named `rdjson`. This reporter prints diagnostics following the [RDJSON format](https://deepwiki.com/reviewdog/reviewdog/3.2-reviewdog-diagnostic-format):
+
+The following command:
+
+```shell
+biome check --reporter=rdjson
+```
+
+Will emit diagnostics in the following format:
+
+```json
+{
+  "source": {
+    "name": "Biome",
+    "url": "https://biomejs.dev"
+  },
+  "diagnostics": [
+    {
+      "code": {
+        "url": "https://biomejs.dev/linter/rules/no-unused-imports",
+        "value": "lint/correctness/noUnusedImports"
+      },
+      "location": {
+        "path": "index.ts",
+        "range": {
+          "end": {
+            "column": 11,
+            "line": 0
+          },
+          "start": {
+            "column": 7,
+            "line": 0
+          }
+        }
+      },
+      "message": "This import is unused."
+    },
+    {
+      "code": {
+        "url": "https://biomejs.dev/linter/rules/no-unused-imports",
+        "value": "lint/correctness/noUnusedImports"
+      },
+      "location": {
+        "path": "index.ts",
+        "range": {
+          "end": {
+            "column": 10,
+            "line": 1
+          },
+          "start": {
+            "column": 9,
+            "line": 1
+          }
+        }
+      },
+      "message": "Several of these imports are unused."
+    }
+  ]
+}
+```

crates/biome_cli/src/cli_options.rs

@@ -56,7 +56,7 @@ pub struct CliOptions {
     /// Allows to change how diagnostics and summary are reported.
     #[bpaf(
         long("reporter"),
-        argument("json|json-pretty|github|junit|summary|gitlab|checkstyle"),
+        argument("json|json-pretty|github|junit|summary|gitlab|checkstyle|rdjson"),
         fallback(CliReporter::default())
     )]
     pub reporter: CliReporter,
@@ -154,12 +154,14 @@ pub enum CliReporter {
     GitHub,
     /// Diagnostics and summary are printed in JUnit format
     Junit,
-    /// Reports linter diagnostics grouped by category and number of hits. Reports formatter diagnostics grouped by file.
+    /// Reports diagnostics grouped by category and number of hits. Reports formatter diagnostics grouped by file.
     Summary,
-    /// Reports linter diagnostics using the [GitLab Code Quality report](https://docs.gitlab.com/ee/ci/testing/code_quality.html#implement-a-custom-tool).
+    /// Reports diagnostics using the [GitLab Code Quality report](https://docs.gitlab.com/ee/ci/testing/code_quality.html#implement-a-custom-tool).
     GitLab,
     /// Reports diagnostics in Checkstyle XML format
     Checkstyle,
+    /// Reports diagnostics using the [Reviewdog JSON format](https://deepwiki.com/reviewdog/reviewdog/3.2-reviewdog-diagnostic-format)
+    RdJson,
 }
 
 impl CliReporter {
@@ -180,6 +182,7 @@ impl FromStr for CliReporter {
             "junit" => Ok(Self::Junit),
             "gitlab" => Ok(Self::GitLab),
             "checkstyle" => Ok(Self::Checkstyle),
+            "rdjson" => Ok(Self::RdJson),
             _ => Err(format!(
                 "value {s:?} is not valid for the --reporter argument"
             )),
@@ -198,6 +201,7 @@ impl Display for CliReporter {
             Self::Junit => f.write_str("junit"),
             Self::GitLab => f.write_str("gitlab"),
             Self::Checkstyle => f.write_str("checkstyle"),
+            Self::RdJson => f.write_str("rdjson"),
         }
     }
 }

crates/biome_cli/src/execute/mod.rs

@@ -14,6 +14,7 @@ use crate::reporter::github::{GithubReporter, GithubReporterVisitor};
 use crate::reporter::gitlab::{GitLabReporter, GitLabReporterVisitor};
 use crate::reporter::json::{JsonReporter, JsonReporterVisitor};
 use crate::reporter::junit::{JunitReporter, JunitReporterVisitor};
+use crate::reporter::rdjson::{RdJsonReporter, RdJsonReporterVisitor};
 use crate::reporter::summary::{SummaryReporter, SummaryReporterVisitor};
 use crate::reporter::terminal::{ConsoleReporter, ConsoleReporterVisitor};
 use crate::{
@@ -249,6 +250,8 @@ pub enum ReportMode {
     GitLab,
     /// Reports diagnostics in [Checkstyle XML format](https://checkstyle.org/).
     Checkstyle,
+    /// Reports information in [reviewdog JSON format](https://deepwiki.com/reviewdog/reviewdog/3.2-reviewdog-diagnostic-format)
+    RdJson,
 }
 
 impl Default for ReportMode {
@@ -272,6 +275,7 @@ impl From<CliReporter> for ReportMode {
             CliReporter::Junit => Self::Junit,
             CliReporter::GitLab => Self::GitLab {},
             CliReporter::Checkstyle => Self::Checkstyle,
+            CliReporter::RdJson => Self::RdJson,
         }
     }
 }
@@ -718,6 +722,15 @@ pub fn execute_mode(
             reporter
                 .write(&mut crate::reporter::checkstyle::CheckstyleReporterVisitor::new(console))?;
         }
+        ReportMode::RdJson => {
+            let reporter = RdJsonReporter {
+                diagnostics_payload,
+                execution: execution.clone(),
+                verbose: cli_options.verbose,
+                working_directory: fs.working_directory().clone(),
+            };
+            reporter.write(&mut RdJsonReporterVisitor(console))?;
+        }
     }
 
     // Processing emitted error diagnostics, exit with a non-zero code

crates/biome_cli/src/reporter/junit.rs

@@ -90,8 +90,8 @@ impl ReporterVisitor for JunitReporterVisitor<'_> {
 
                 status.set_description(format!(
                     "line {row:?}, col {col:?}, {body}",
-                    row = start.line_number.to_zero_indexed(),
-                    col = start.column_number.to_zero_indexed(),
+                    row = start.line_number.get(),
+                    col = start.column_number.get(),
                     body = message
                 ));
                 let mut case = TestCase::new(

crates/biome_cli/src/reporter/mod.rs

@@ -3,6 +3,7 @@ pub(crate) mod github;
 pub(crate) mod gitlab;
 pub(crate) mod json;
 pub(crate) mod junit;
+pub(crate) mod rdjson;
 pub(crate) mod summary;
 pub(crate) mod terminal;