fix(lsp): load extension settings before configuration on document open (#7764)

Author: gaauwe

.changeset/swift-apples-greet.md

@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed [#6589](https://github.com/biomejs/biome/issues/6589): Biome now properly loads extension settings before loading the configuration file when opening a text document in the LSP server.

crates/biome_lsp/src/handlers/text_document.rs

@@ -75,6 +75,9 @@ pub(crate) async fn did_open(
                 "Loading configuration from text_document {:?}",
                 &project_path
             );
+            if !session.has_initialized() {
+                session.load_extension_settings().await;
+            }
             let status = session
                 .load_biome_configuration_file(ConfigurationPathHint::FromLsp(project_path), false)
                 .await;

crates/biome_lsp/src/server.rs

@@ -314,6 +314,7 @@ impl LanguageServer for LSPServer {
         self.session.load_extension_settings().await;
         self.session.load_workspace_settings(false).await;
 
+        self.session.set_initialized();
         let msg = format!("Server initialized with PID: {}", std::process::id());
         self.session
             .client

crates/biome_lsp/src/session.rs

@@ -86,6 +86,9 @@ pub(crate) struct Session {
     /// to update the diagnostics
     notified_broken_configuration: AtomicBool,
 
+    /// Tracks whether the initialized() notification has been received
+    initialized: AtomicBool,
+
     /// Projects opened in this session, mapped from the project's root path to
     /// the associated project key.
     projects: HashMap<BiomePath, ProjectKey>,
@@ -213,6 +216,7 @@ impl Session {
             extension_settings: config,
             cancellation,
             notified_broken_configuration: AtomicBool::new(false),
+            initialized: AtomicBool::new(false),
             service_rx,
             loading_operations: Default::default(),
             workspace_folders: Default::default(),
@@ -623,6 +627,16 @@ impl Session {
         self.initialize_params.get()?.client_information.as_ref()
     }
 
+    /// Mark that the initialized() notification has been received
+    pub(crate) fn set_initialized(&self) {
+        self.initialized.store(true, Ordering::Relaxed);
+    }
+
+    /// Returns true if the initialized() notification has been received
+    pub(crate) fn has_initialized(&self) -> bool {
+        self.initialized.load(Ordering::Relaxed)
+    }
+
     /// This function attempts to read the `biome.json` configuration file from
     /// the root URI and update the workspace settings accordingly
     #[tracing::instrument(level = "debug", skip(self))]