feat(lint): implement noIncrementDecrement (#7859)

Author: Netail

.changeset/cool-drinks-dress.md

@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": patch
+---
+
+Added the nursery rule [`noIncrementDecrement`](https://biomejs.dev/linter/rules/no-increment-decrement/), disallows the usage of the unary operators ++ and --.

crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs

@@ -171,6 +171,7 @@ define_categories! {
     "lint/nursery/noFloatingPromises": "https://biomejs.dev/linter/rules/no-floating-promises",
     "lint/nursery/noImplicitCoercion": "https://biomejs.dev/linter/rules/no-implicit-coercion",
     "lint/nursery/noImportCycles": "https://biomejs.dev/linter/rules/no-import-cycles",
+    "lint/nursery/noIncrementDecrement": "https://biomejs.dev/linter/rules/no-increment-decrement",
     "lint/nursery/noJsxLiterals": "https://biomejs.dev/linter/rules/no-jsx-literals",
     "lint/nursery/noMissingGenericFamilyKeyword": "https://biomejs.dev/linter/rules/no-missing-generic-family-keyword",
     "lint/nursery/noMisusedPromises": "https://biomejs.dev/linter/rules/no-misused-promises",

crates/biome_configuration/src/analyzer/linter/rules.rs

@@ -7,6 +7,7 @@ pub mod no_deprecated_imports;
 pub mod no_empty_source;
 pub mod no_floating_promises;
 pub mod no_import_cycles;
+pub mod no_increment_decrement;
 pub mod no_jsx_literals;
 pub mod no_misused_promises;
 pub mod no_next_async_client_component;
@@ -30,4 +31,4 @@ pub mod use_qwik_valid_lexical_scope;
 pub mod use_sorted_classes;
 pub mod use_vue_define_macros_order;
 pub mod use_vue_multi_word_component_names;
-declare_lint_group! { pub Nursery { name : "nursery" , rules : [self :: no_deprecated_imports :: NoDeprecatedImports , self :: no_empty_source :: NoEmptySource , self :: no_floating_promises :: NoFloatingPromises , self :: no_import_cycles :: NoImportCycles , self :: no_jsx_literals :: NoJsxLiterals , self :: no_misused_promises :: NoMisusedPromises , self :: no_next_async_client_component :: NoNextAsyncClientComponent , self :: no_react_forward_ref :: NoReactForwardRef , self :: no_shadow :: NoShadow , self :: no_unnecessary_conditions :: NoUnnecessaryConditions , self :: no_unresolved_imports :: NoUnresolvedImports , self :: no_unused_expressions :: NoUnusedExpressions , self :: no_useless_catch_binding :: NoUselessCatchBinding , self :: no_useless_undefined :: NoUselessUndefined , self :: no_vue_data_object_declaration :: NoVueDataObjectDeclaration , self :: no_vue_duplicate_keys :: NoVueDuplicateKeys , self :: no_vue_reserved_keys :: NoVueReservedKeys , self :: no_vue_reserved_props :: NoVueReservedProps , self :: use_consistent_arrow_return :: UseConsistentArrowReturn , self :: use_exhaustive_switch_cases :: UseExhaustiveSwitchCases , self :: use_explicit_type :: UseExplicitType , self :: use_max_params :: UseMaxParams , self :: use_qwik_method_usage :: UseQwikMethodUsage , self :: use_qwik_valid_lexical_scope :: UseQwikValidLexicalScope , self :: use_sorted_classes :: UseSortedClasses , self :: use_vue_define_macros_order :: UseVueDefineMacrosOrder , self :: use_vue_multi_word_component_names :: UseVueMultiWordComponentNames ,] } }
+declare_lint_group! { pub Nursery { name : "nursery" , rules : [self :: no_deprecated_imports :: NoDeprecatedImports , self :: no_empty_source :: NoEmptySource , self :: no_floating_promises :: NoFloatingPromises , self :: no_import_cycles :: NoImportCycles , self :: no_increment_decrement :: NoIncrementDecrement , self :: no_jsx_literals :: NoJsxLiterals , self :: no_misused_promises :: NoMisusedPromises , self :: no_next_async_client_component :: NoNextAsyncClientComponent , self :: no_react_forward_ref :: NoReactForwardRef , self :: no_shadow :: NoShadow , self :: no_unnecessary_conditions :: NoUnnecessaryConditions , self :: no_unresolved_imports :: NoUnresolvedImports , self :: no_unused_expressions :: NoUnusedExpressions , self :: no_useless_catch_binding :: NoUselessCatchBinding , self :: no_useless_undefined :: NoUselessUndefined , self :: no_vue_data_object_declaration :: NoVueDataObjectDeclaration , self :: no_vue_duplicate_keys :: NoVueDuplicateKeys , self :: no_vue_reserved_keys :: NoVueReservedKeys , self :: no_vue_reserved_props :: NoVueReservedProps , self :: use_consistent_arrow_return :: UseConsistentArrowReturn , self :: use_exhaustive_switch_cases :: UseExhaustiveSwitchCases , self :: use_explicit_type :: UseExplicitType , self :: use_max_params :: UseMaxParams , self :: use_qwik_method_usage :: UseQwikMethodUsage , self :: use_qwik_valid_lexical_scope :: UseQwikValidLexicalScope , self :: use_sorted_classes :: UseSortedClasses , self :: use_vue_define_macros_order :: UseVueDefineMacrosOrder , self :: use_vue_multi_word_component_names :: UseVueMultiWordComponentNames ,] } }

crates/biome_diagnostics_categories/src/categories.rs

@@ -0,0 +1,198 @@
+use biome_analyze::{
+    Ast, Rule, RuleDiagnostic, RuleSource, context::RuleContext, declare_lint_rule,
+};
+use biome_console::markup;
+use biome_js_syntax::{JsLanguage, JsPostUpdateExpression, JsPreUpdateExpression, JsSyntaxKind};
+use biome_rowan::{AstNode, SyntaxNode, declare_node_union};
+use biome_rule_options::no_increment_decrement::NoIncrementDecrementOptions;
+
+declare_lint_rule! {
+    /// Disallows the usage of the unary operators ++ and --.
+    ///
+    /// Because the unary ++ and -- operators are subject to automatic semicolon insertion, differences in whitespace can change semantics of source code.
+    ///
+    /// ```js,expect_diagnostic
+    /// let i = 10;
+    /// let j = 20;
+    ///
+    /// i ++
+    /// j
+    /// // i = 11, j = 20
+    /// ```
+    ///
+    /// ```js,expect_diagnostic
+    /// let i = 10;
+    /// let j = 20;
+    ///
+    /// i
+    /// ++
+    /// j
+    /// // i = 10, j = 21
+    /// ```
+    ///
+    /// ## Examples
+    ///
+    /// ### Invalid
+    ///
+    /// ```js,expect_diagnostic
+    /// let foo = 0;
+    /// foo++;
+    /// ```
+    ///
+    /// ```js,expect_diagnostic
+    /// let bar = 42;
+    /// bar--;
+    /// ```
+    ///
+    /// ```js,expect_diagnostic
+    /// for (let i = 0; i < 10; i++) {
+    ///     doSomething(i);
+    /// }
+    /// ```
+    ///
+    /// ```js,expect_diagnostic
+    /// for (let i = 0; i < 10;) {
+    ///     doSomething(i);
+    ///     i++;
+    /// }
+    /// ```
+    ///
+    /// ### Valid
+    ///
+    /// ```js
+    /// let foo = 0;
+    /// foo += 1;
+    /// ```
+    ///
+    /// ```js
+    /// let bar = 42;
+    /// bar -= 1;
+    /// ```
+    ///
+    /// ```js
+    /// for (let i = 0; i < 10; i += 1) {
+    ///     doSomething(i);
+    /// }
+    /// ```
+    ///
+    /// ```js
+    /// for (let i = 0; i < 10;) {
+    ///     doSomething(i);
+    ///     i += 1;
+    /// }
+    /// ```
+    ///
+    /// ## Options
+    ///
+    /// ### `allowForLoopAfterthoughts`
+    ///
+    /// Allows unary operators ++ and -- in the afterthought (final expression) of a for loop.
+    ///
+    /// Default `false`
+    ///
+    /// ```json,options
+    /// {
+    ///   "options": {
+    ///     "allowForLoopAfterthoughts": true
+    ///   }
+    /// }
+    /// ```
+    ///
+    /// #### Invalid
+    ///
+    /// ```js,expect_diagnostic,use_options
+    /// for (let i = 0; i < j; j = i++) {
+    ///     doSomething(i, j);
+    /// }
+    /// ```
+    ///
+    /// ```js,expect_diagnostic,use_options
+    /// for (let i = 10; i--;) {
+    ///     doSomething(i);
+    /// }
+    /// ```
+    ///
+    /// ```js,expect_diagnostic,use_options
+    /// for (let i = 0; i < 10;) i++;
+    /// ```
+    ///
+    /// #### Valid
+    ///
+    /// ```js,use_options
+    /// for (let i = 0; i < 10; i++) {
+    ///     doSomething(i);
+    /// }
+    /// ```
+    ///
+    /// ```js,use_options
+    /// for (let i = 0, j = l; i < l; i++, j--) {
+    ///     doSomething(i, j);
+    /// }
+    /// ```
+    ///
+    pub NoIncrementDecrement {
+        version: "next",
+        name: "noIncrementDecrement",
+        language: "js",
+        recommended: false,
+        sources: &[RuleSource::Eslint("no-plusplus").same()],
+    }
+}
+
+declare_node_union! {
+    pub NoIncrementDecrementQuery = JsPreUpdateExpression | JsPostUpdateExpression
+}
+
+impl Rule for NoIncrementDecrement {
+    type Query = Ast<NoIncrementDecrementQuery>;
+    type State = ();
+    type Signals = Option<Self::State>;
+    type Options = NoIncrementDecrementOptions;
+
+    fn run(ctx: &RuleContext<Self>) -> Self::Signals {
+        let node = ctx.query();
+
+        if ctx.options().allow_for_loop_afterthoughts && is_for_loop_afterthought(node.syntax()) {
+            return None;
+        }
+
+        Some(())
+    }
+
+    fn diagnostic(ctx: &RuleContext<Self>, _state: &Self::State) -> Option<RuleDiagnostic> {
+        let node = ctx.query();
+        Some(
+            RuleDiagnostic::new(
+                rule_category!(),
+                node.range(),
+                markup! {
+                    "Unexpected use of increment/decrement unary operator."
+                },
+            )
+            .note(markup! {
+                "The unary ++ and -- operators are subject to automatic semicolon insertion, differences in whitespace can change semantics of source code. Instead use += or -=."
+            }),
+        )
+    }
+}
+
+fn is_for_loop_afterthought(node: &SyntaxNode<JsLanguage>) -> bool {
+    let Some(parent) = node.parent() else {
+        return false;
+    };
+
+    match parent.kind() {
+        JsSyntaxKind::JS_PARENTHESIZED_EXPRESSION | JsSyntaxKind::JS_SEQUENCE_EXPRESSION => {
+            is_for_loop_afterthought(&parent)
+        }
+        JsSyntaxKind::JS_FOR_STATEMENT => {
+            if let Some(for_stmt) = biome_js_syntax::JsForStatement::cast(parent.clone())
+                && let Some(update) = for_stmt.update()
+            {
+                return update.syntax().eq(node);
+            }
+            false
+        }
+        _ => false,
+    }
+}

crates/biome_js_analyze/src/lint/nursery.rs

@@ -0,0 +1,29 @@
+let foo = 0;
+foo++;
+
+let bar = 0;
+++bar;
+
+for (let i = 0; i < 10; j = i++) {
+	doSomething(i, j);
+}
+
+for (let i = 10; i--;) {
+	doSomething(i);
+}
+
+for (let i = 0; i < 10;) i++;
+
+for (i = 0; i < l; i++) { v++; }
+
+for (i++;;);
+
+for (;--i;);
+
+for (;;) ++i;
+
+for (;; i = j++);
+
+for (;; i++, f(--j));
+
+for (;; foo + (i++, bar));