fix(biome_analyze): handle suppressed categories properly for range suppressions (#8182)

Author: hirokiokada77

.changeset/rare-bees-hug.md

@@ -0,0 +1,13 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed [#7877](https://github.com/biomejs/biome/issues/7877): Range suppressions now handle suppressed categories properly.
+
+**Valid:**
+
+```js
+// biome-ignore-start lint: explanation
+const foo = 1;
+// biome-ignore-end lint: explanation
+```

crates/biome_analyze/src/suppressions.rs

@@ -276,10 +276,12 @@ impl RangeSuppressions {
             }
 
             let range_suppression = match filter {
-                None => {
-                    self.suppressions.pop();
-                    return Ok(());
-                }
+                None => self
+                    .suppressions
+                    .iter_mut()
+                    .rev()
+                    .filter(|s| !s.is_ended)
+                    .find(|s| s.suppressed_categories.contains(suppression.category)),
                 Some(PLUGIN_LINT_RULE_FILTER) => self
                     .suppressions
                     .iter_mut()
@@ -334,10 +336,13 @@ impl RangeSuppressions {
             if range_suppression
                 .suppression_range
                 .contains_range(*position)
-                && range_suppression
-                    .filters_by_category
-                    .get(rule_category)
-                    .is_some_and(|filters| filters.iter().any(|f| f == filter))
+                && (range_suppression
+                    .suppressed_categories
+                    .contains(rule_category)
+                    || range_suppression
+                        .filters_by_category
+                        .get(rule_category)
+                        .is_some_and(|filters| filters.iter().any(|f| f == filter)))
             {
                 range_suppression.did_suppress_signal = true;
                 return true;

crates/biome_cli/tests/cases/suppressions.rs

@@ -458,6 +458,37 @@ function sommething(chalk: ChalkInstance) {
     ));
 }
 
+#[test]
+fn syntax_rule_range_suppression_category_only() {
+    let fs = MemoryFileSystem::default();
+    let mut console = BufferConsole::default();
+
+    let file_path = Utf8Path::new("file.ts");
+    fs.insert(
+        file_path.into(),
+        *b"
+// biome-ignore-start lint: explanation
+const foo = 1;
+// biome-ignore-end lint: explanation",
+    );
+
+    let (fs, result) = run_cli(
+        fs,
+        &mut console,
+        Args::from(["lint", file_path.as_str()].as_slice()),
+    );
+
+    assert!(result.is_ok(), "run_cli returned {result:?}");
+
+    assert_cli_snapshot(SnapshotPayload::new(
+        module_path!(),
+        "syntax_rule_range_suppression_category_only",
+        fs,
+        console,
+        result,
+    ));
+}
+
 #[test]
 fn syntax_rule_top_suppression() {
     let fs = MemoryFileSystem::default();

crates/biome_cli/tests/snapshots/main_cases_suppressions/syntax_rule_range_suppression_category_only.snap

@@ -0,0 +1,18 @@
+---
+source: crates/biome_cli/tests/snap_test.rs
+expression: redactor(content)
+---
+## `file.ts`
+
+```ts
+
+// biome-ignore-start lint: explanation
+const foo = 1;
+// biome-ignore-end lint: explanation
+```
+
+# Emitted Messages
+
+```block
+Checked 1 file in <TIME>. No fixes applied.
+```