Skip to content

Commit 7045a90

Browse files
committed
Ignore clang's self-assignment check
As-documented in the code, this is already safe so ignore the false-positive.
1 parent e2f10b4 commit 7045a90

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

include/leveldb/status.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,8 @@ class LEVELDB_EXPORT Status {
103103
inline Status::Status(const Status& rhs) {
104104
state_ = (rhs.state_ == nullptr) ? nullptr : CopyState(rhs.state_);
105105
}
106+
107+
// NOLINTBEGIN(bugprone-unhandled-self-assignment)
106108
inline Status& Status::operator=(const Status& rhs) {
107109
// The following condition catches both aliasing (when this == &rhs),
108110
// and the common case where both rhs and *this are ok.
@@ -112,6 +114,8 @@ inline Status& Status::operator=(const Status& rhs) {
112114
}
113115
return *this;
114116
}
117+
// NOLINTEND(bugprone-unhandled-self-assignment)
118+
115119
inline Status& Status::operator=(Status&& rhs) noexcept {
116120
std::swap(state_, rhs.state_);
117121
return *this;

0 commit comments

Comments
 (0)