Skip to content

Commit d73ed99

Browse files
RandomLatticeandozw
andcommitted
tests: update wycheproof files
Wycheproof ownership was recently moved to C2SP (https://github.com/C2SP/wycheproof). This PR updates all references to the new URL and bumps to the latest version of the vector files. This commit does not change the content of processed .h testvector files. To test: ``` make clean-testvectors testvectors ``` See: #1492 (comment) Co-authored-by: Sean Andersen <[email protected]>
1 parent 4187a46 commit d73ed99

File tree

4 files changed

+13
-10
lines changed

4 files changed

+13
-10
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ We strongly recommend updating to 0.3.1 if you use or plan to use Clang >=14 to
115115
- Fix "constant-timeness" issue with Clang >=14 that could leave applications using libsecp256k1 vulnerable to a timing side-channel attack. The fix avoids secret-dependent control flow and secret-dependent memory accesses in conditional moves of memory objects when libsecp256k1 is compiled with Clang >=14.
116116

117117
#### Added
118-
- Added tests against [Project Wycheproof's](https://github.com/google/wycheproof/) set of ECDSA test vectors (Bitcoin "low-S" variant), a fixed set of test cases designed to trigger various edge cases.
118+
- Added tests against [Project Wycheproof's](https://github.com/C2SP/wycheproof/) set of ECDSA test vectors (Bitcoin "low-S" variant), a fixed set of test cases designed to trigger various edge cases.
119119

120120
#### Changed
121121
- Increased minimum required CMake version to 3.13. CMake builds remain experimental.

src/wycheproof/WYCHEPROOF_COPYING

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
* The file `ecdsa_secp256k1_sha256_bitcoin_test.json` in this directory
2-
comes from Google's project Wycheproof with git commit
3-
`b063b4aedae951c69df014cd25fa6d69ae9e8cb9`, see
4-
https://github.com/google/wycheproof/blob/b063b4aedae951c69df014cd25fa6d69ae9e8cb9/testvectors_v1/ecdsa_secp256k1_sha256_bitcoin_test.json
2+
comes from project Wycheproof with git commit
3+
`df4e933efef449fc88af0c06e028d425d84a9495`, see
4+
https://github.com/C2SP/wycheproof/blob/df4e933efef449fc88af0c06e028d425d84a9495/testvectors_v1/ecdsa_secp256k1_sha256_bitcoin_test.json
55

66
* The file `ecdh_secp256k1_test.json` in this directory
7-
comes from Google's project Wycheproof with git commit
8-
`d9f6ec7d8bd8c96da05368999094e4a75ba5cb3d`, see
9-
https://github.com/google/wycheproof/blob/d9f6ec7d8bd8c96da05368999094e4a75ba5cb3d/testvectors_v1/ecdh_secp256k1_test.json
7+
comes from project Wycheproof with git commit
8+
`df4e933efef449fc88af0c06e028d425d84a9495`, see
9+
https://github.com/C2SP/wycheproof/blob/df4e933efef449fc88af0c06e028d425d84a9495/testvectors_v1/ecdh_secp256k1_test.json
1010

1111
* The file `ecdsa_secp256k1_sha256_bitcoin_test.h` is generated from
1212
`ecdsa_secp256k1_sha256_bitcoin_test.json` using the script

src/wycheproof/ecdh_secp256k1_test.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
{
22
"algorithm" : "ECDH",
33
"schema" : "ecdh_test_schema.json",
4-
"generatorVersion" : "0.9rc5",
54
"numberOfTests" : 752,
65
"header" : [
76
"Test vectors of type EcdhTest are intended for",
@@ -124,6 +123,10 @@
124123
"testGroups" : [
125124
{
126125
"type" : "EcdhTest",
126+
"source" : {
127+
"name" : "google-wycheproof",
128+
"version" : "0.9rc5"
129+
},
127130
"curve" : "secp256k1",
128131
"encoding" : "asn",
129132
"tests" : [

src/wycheproof/ecdsa_secp256k1_sha256_bitcoin_test.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"notes" : {
1111
"ArithmeticError" : {
1212
"bugType" : "EDGE_CASE",
13-
"description" : "Some implementations of ECDSA have arithmetic errors that occur when intermediate results have extreme values. This test vector has been constructed to test such occurences.",
13+
"description" : "Some implementations of ECDSA have arithmetic errors that occur when intermediate results have extreme values. This test vector has been constructed to test such occurrences.",
1414
"cves" : [
1515
"CVE-2017-18146"
1616
]
@@ -95,7 +95,7 @@
9595
},
9696
"SignatureMalleabilityBitcoin" : {
9797
"bugType" : "SIGNATURE_MALLEABILITY",
98-
"description" : "\"BitCoins\"-curves are curves where signature malleability can be a serious issue. An implementation should only accept a signature s where s < n/2. If an implementation is not meant for uses cases that require signature malleability then this implemenation should be tested with another set of test vectors.",
98+
"description" : "\"BitCoins\"-curves are curves where signature malleability can be a serious issue. An implementation should only accept a signature s where s < n/2. If an implementation is not meant for uses cases that require signature malleability then this implementation should be tested with another set of test vectors.",
9999
"effect" : "In bitcoin exchanges, it may be used to make a double deposits or double withdrawals",
100100
"links" : [
101101
"https://en.bitcoin.it/wiki/Transaction_malleability",

0 commit comments

Comments
 (0)